Skip to content

Fix nil ptr deref on Windows/Linux when keychain flags are used #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
csstaub merged 1 commit into from
Apr 29, 2024
Merged

Fix nil ptr deref on Windows/Linux when keychain flags are used #448

csstaub merged 1 commit into from
Apr 29, 2024

Conversation

@csstaub
Copy link
Member

@csstaub csstaub commented Apr 23, 2024 •
edited
Loading

Fix nil ptr deref on Windows/Linux when keychain flags are used.

The panic comes from line 67 in tls.go:

	if hasKeychainIdentity() {
		logger.Printf("using operating system keychain as certificate source")
		return certloader.CertificateFromKeychainIdentity(*keychainIdentity, *keychainIssuer, caBundlePath, *keychainRequireToken)
	}

Flag keychainRequireToken can't be nil, even if it's not supported on Windows/Linux.

@codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.23%. Comparing base (04b717c) to head (e11ae8a).
Report is 64 commits behind head on master.

Files Patch % Lines
main.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   78.48%   81.23%   +2.75%     
==========================================
  Files          30       35       +5     
  Lines        2133     1828     -305     
==========================================
- Hits         1674     1485     -189     
+ Misses        379      255     -124     
- Partials       80       88       +8
Flag Coverage Δ
darwin 79.26% <75.00%> (+1.81%) ⬆️
linux 85.52% <0.00%> (+1.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csstaub csstaub merged commit f38441a into master Apr 29, 2024
@csstaub csstaub deleted the cs/keychain-windows-fix branch April 29, 2024 16:29
@BrewTestBot BrewTestBot mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@csstaub