Skip to content

Initial landlock implementation #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
csstaub merged 4 commits into from
Apr 13, 2024
Merged

Initial landlock implementation #431

csstaub merged 4 commits into from
Apr 13, 2024

Conversation

@csstaub
Copy link
Member

@csstaub csstaub commented Apr 8, 2024 •
edited
Loading

Initial landlock implementation for Ghostunnel:

  • Adds ability to enable landlock via the --use-landlock flag. Landlock rules are generated based on flag values. The rule set is not as restrictive as it could be, I tried to strike a practical balance between security and maintainability.
  • Unfortunately this isn't compatible with PKCS#11, because a PKCS#11 module is an SO with arbitrary code and there's no way we can know what it does/what policies it needs. I tried making it work with SoftHSM2 but even that was an exercise in frustration.

@csstaub csstaub force-pushed the cs/landlock branch 8 times, most recently from 184ce72 to 2bcbd31 Compare April 12, 2024 23:20
@csstaub csstaub changed the title Work in Progress - Initial landlock implementation Initial landlock implementation Apr 13, 2024
@codecov
Copy link

codecov bot commented Apr 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.24590% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 81.36%. Comparing base (7c03fa3) to head (53917f4).

Files Patch % Lines
landlock_linux.go 86.48% 8 Missing and 7 partials ⚠️
landlock_other.go 33.33% 2 Missing ⚠️
main.go 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #431       +/-   ##
===========================================
+ Coverage   71.17%   81.36%   +10.19%     
===========================================
  Files          38       35        -3     
  Lines        2213     1825      -388     
===========================================
- Hits         1575     1485       -90     
+ Misses        548      253      -295     
+ Partials       90       87        -3
Flag Coverage Δ
darwin 79.41% <27.27%> (+9.48%) ⬆️
linux 85.70% <86.55%> (+13.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csstaub csstaub merged commit defebe2 into master Apr 13, 2024
@csstaub csstaub deleted the cs/landlock branch April 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@csstaub