cats-effect 3 and http4s 0.23.0 by iRevive · Pull Request #891 · ghostdogpr/caliban

iRevive · 2021-05-19T12:43:04Z

This PR brings support of cats-effect 3.2.1 and http4s 0.23.

.circleci/config.yml

adapters/http4s/src/main/scala/caliban/Http4sAdapter.scala

ghostdogpr

I was waiting for a stable http4s release to start, good that you got ahead of me 😄
I need to dig into CE3, I imagine there is no way out of using Futures?

interop/cats/src/main/scala/caliban/interop/cats/implicits/package.scala

iRevive · 2021-07-31T05:22:35Z

@ghostdogpr a stable version of http4s has been released. I will update the PR today

# Conflicts: # .circleci/config.yml # adapters/http4s/src/main/scala/caliban/Http4sAdapter.scala # build.sbt # examples/src/main/scala/example/federation/FederatedApp.scala # examples/src/main/scala/example/http4s/AuthExampleApp.scala # examples/src/main/scala/example/http4s/ExampleApp.scala # examples/src/main/scala/example/tapir/ExampleApp.scala

iRevive · 2021-07-31T06:49:18Z

I need to dig into CE3, I imagine there is no way out of using Futures?

Yes, in CE3 futures the only way to materialize the effect. (apart from the .unsafeRunSync())

ghostdogpr · 2021-07-31T07:14:23Z

To not be blocked by finch and monix, we could let them depend on CE2 and upgrade only http4s and cats interop. I believe they are independent. Wdyt?

iRevive · 2021-07-31T07:24:18Z

Sounds good to me. I will adjust the dependencies.

iRevive · 2021-07-31T07:34:27Z

How should we deal with the examples project? We should keep either http4s + catsInterop or finch + monix.
Otherwise, we will have dependencies conflict.

As an option, I can make a separate project (e.g. examples-2) and move finch and monix examples there.

ghostdogpr · 2021-07-31T07:42:29Z

Ah, right, didn't think of that 😢
Considering monix and finch are much less used than cats-effect/http4s, maybe we just comment out the example code for those 2. So people who need it will still find the code, and we don't bother splitting the examples project. And we can uncomment when they are available.

Maybe just add a comment at the top of the file to explain why it's commented out.

iRevive · 2021-07-31T07:54:29Z

adapters/http4s/src/main/scala/caliban/Http4sAdapter.scala

    }

-  def makeWebSocketService[R, E](
+  def makeWebSocketService[R <: Has[_] with Clock with Blocking, E](


Unfortunately, the compilation fails without <: Has[_] with Clock with Blocking in Scala 3.

But compiles fine in 2.13.6.

Where does the constraint come from?

I tried your branch and was able to make it work: change the queues to be of Task instead of RIO[R, *] and it will solve the problem. You also need to put .provideLayer(Clock.live) back.

There's still an error but I think it's something else.

I think I made it work, will open a PR to your repo.

I was able to push to your branch directly, you can have a look

iRevive · 2021-07-31T08:11:03Z

I've updated the docs and the definition of the build.

ghostdogpr · 2021-07-31T07:45:40Z

build.sbt

  .settings(name := "caliban-http4s")
  .settings(commonSettings)
  .settings(
-    crossScalaVersions -= scala3,


It supports scala 3, nice!

ghostdogpr · 2021-07-31T08:18:19Z

adapters/http4s/src/main/scala/caliban/Http4sAdapter.scala

    }

-  def makeWebSocketService[R, E](
+  def makeWebSocketService[R <: Has[_] with Clock with Blocking, E](


Where does the constraint come from?

iRevive · 2021-07-31T12:36:04Z

adapters/http4s/src/main/scala/caliban/Http4sAdapter.scala

              msg    <- RIO.fromEither(decode[Json](text))
              msgType = msg.hcursor.downField("type").success.flatMap(_.value.asString).getOrElse("")
-              _      <- RIO.whenCase(msgType) {
+              _      <- RIO.whenCase[R, String](msgType) {


I guess it didn't compile in Scala 3 because explicit types were missing.

Yeah weirdly this one seems necessary with Scala 3.

iRevive · 2021-07-31T12:36:32Z

@ghostdogpr thank you for the improvements. Looks much better now

ghostdogpr · 2021-08-01T07:26:57Z

Can you resolve the conflict in build.sbt? Then I can merge it. Thanks!

# Conflicts: # build.sbt

Update cats-effect to 3.1.0 and http4s to 1.0.0-M21

52a74d3

iRevive force-pushed the cats-effect-3 branch from efff618 to 52a74d3 Compare May 19, 2021 12:46

Do not run tests for finch and monix modules

f934514

iRevive commented May 19, 2021

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

iRevive commented May 19, 2021

View reviewed changes

adapters/http4s/src/main/scala/caliban/Http4sAdapter.scala Outdated Show resolved Hide resolved

Fix compilation issues

445fe8d

iRevive force-pushed the cats-effect-3 branch from 3bccd05 to 445fe8d Compare May 19, 2021 13:09

ghostdogpr reviewed May 19, 2021

View reviewed changes

interop/cats/src/main/scala/caliban/interop/cats/implicits/package.scala Outdated Show resolved Hide resolved

Remove redundant Async constraint

40da4fc

kubukoz mentioned this pull request May 22, 2021

Ecosystem upgrade megathread typelevel/cats-effect#1330

Closed

iRevive added 5 commits July 31, 2021 08:48

Update dependencies. Support Scala 3 in http4s module

4c99c25

Run 'fmt'

47b277f

Fix http4s tests

0053d6d

Use WebSocketBuilder.build(...) instead of the constructor

194e525

iRevive changed the title ~~WIP: CE 3~~ WIP: CE 3 and http4s 0.23.0 Jul 31, 2021

Use cats-effect 2 for monix and finch modules

746cd6b

iRevive force-pushed the cats-effect-3 branch from dc9297a to a267714 Compare July 31, 2021 07:49

Move finch and monix examples to the 'cats-effect 2' section

d8a6663

iRevive force-pushed the cats-effect-3 branch from a267714 to d8a6663 Compare July 31, 2021 07:50

iRevive commented Jul 31, 2021

View reviewed changes

iRevive changed the title ~~WIP: CE 3 and http4s 0.23.0~~ cats-effect 3 and http4s 0.23.0 Jul 31, 2021

ghostdogpr reviewed Jul 31, 2021

View reviewed changes

ghostdogpr added 2 commits July 31, 2021 17:49

Remove constraint

4445420

Remove constraint in F variant too

917eb0a

iRevive commented Jul 31, 2021

View reviewed changes

Merge branch 'upstream-master' into cats-effect-3

5f9a60b

# Conflicts: # build.sbt

ghostdogpr merged commit 8ce38b8 into ghostdogpr:master Aug 1, 2021

Uh oh!

Conversation

iRevive commented May 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghostdogpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iRevive commented Jul 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iRevive commented Jul 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghostdogpr commented Jul 31, 2021

Uh oh!

iRevive commented Jul 31, 2021

Uh oh!

iRevive commented Jul 31, 2021

Uh oh!

ghostdogpr commented Jul 31, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iRevive commented Jul 31, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iRevive commented Jul 31, 2021

Uh oh!

ghostdogpr commented Aug 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

iRevive commented May 19, 2021 •

edited

Loading

iRevive commented Jul 31, 2021 •

edited

Loading

iRevive commented Jul 31, 2021 •

edited

Loading