[SYCL ]add build shared lib in win release package #7438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofosyne
added
build
airMeng
reviewed
May 22, 2024
Contributor
airMeng
left a comment
airMeng
left a comment
There was a problem hiding this comment.
why put it as default behavior?
the other release packages contain llama.dll (and this makes them convenient to use them with LLamaSharp) so I thought it was unexpected that it's missing from the sycl package and opened #7361 |
Collaborator
The windows release package is used to direct user or developer who call llama.dll in other project. |
airMeng
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add build shared lib (like llama.dll) in win release package