Apply formatting to python code #611
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This will have to wait for a while - there are too many pending changes to the python code that I don't want to be delayed by this formatting change |
Contributor
|
This kind of change is not very useful at this moment. Try again in few weeks, when there is not so much development around the Python tooling. |
Contributor
|
Also, keep an eye on pull requests that modify Python code. You can contribute suggestions by reviewing individual PRs, ensuring that the small changes added to the repository already have proper formatting. |
Author
|
Thanks, I will keep that into account. |
Deadsg
pushed a commit
to Deadsg/llama.cpp
that referenced
this pull request
Dec 19, 2023
…ette-1.6.5 Bump sse-starlette from 1.6.1 to 1.6.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great if python code is appropriately formatted with Black to improve the readability of code while following psf foundation-based guidelines!
Usage is pretty simple:
>black $file_nameHappy to answer any questions :)
🤖 Generated by Copilot at 81b8748
Summary
🎨📝🚚
Reformatted several Python scripts to follow PEP8 style and improve readability. No changes to functionality or logic. The scripts are used to convert different formats of graph models to the GGML format used by llama.cpp.
Walkthrough
write_headerfunctions ofconvert-gpt4all-to-ggml.py,convert-gptq-to-ggml.py, andconvert-unversioned-ggml-to-ggml.pyfor consistency with other scripts (link,link,link)rotandftypeparameters inconvert-gptq-to-ggml.pyfor clarity (link,link)convert-ggml-to-pth.pyandconvert-gptq-to-ggml.pyfor readability (link,link,link)convert-ggml-to-pth.pyfor consistency (link)quantize.pyfor compactness (link,link)