Skip to content

Added AVX512F macros to ggml.c #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggerganov merged 1 commit into from
Mar 16, 2024
Merged

Added AVX512F macros to ggml.c #6088

ggerganov merged 1 commit into from
Mar 16, 2024

Conversation

@amiralimi
Copy link
Contributor

@amiralimi amiralimi commented Mar 15, 2024

Hi.
I added AVX512F macros to ggml.c. For commiting I ran pre-commit too. I wanted to add AVX512_FP16 support too, but I didn't have a hardware that supports it.

This change showed speed-up when running F16 and F32 models. Here are the results:

Results

avx512 - fp16
llama_print_timings:        50 runs   (  453.77 ms per token,     2.20 tokens per second)

avx - fp16
llama_print_timings:        50 runs   (  625.48 ms per token,     1.60 tokens per second)

avx512 - fp32
llama_print_timings:        50 runs   (  517.39 ms per token,     1.93 tokens per second)

avx - fp32
llama_print_timings:        50 runs   (  638.76 ms per token,     1.57 tokens per second)

I don't know if I need to add more things for this change (I'm new to open-source development).

ggerganov
ggerganov approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ggerganov ggerganov merged commit c47cf41 into ggml-org:master Mar 16, 2024
@amiralimi amiralimi deleted the avx512 branch March 16, 2024 17:34
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
@amiralimi @hodlen
ggml : add AVX512F SIMD (ggml-org#6088)
ac48d78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amiralimi @ggerganov