Skip to content

Conversation

@phymbert
Copy link
Collaborator

@phymbert phymbert commented Mar 8, 2024

Context

Tests were not using acurrate KV Cache size to process entire prompt, inputs were truncated.

Changes

Add good configuration to have relevant test.
Added few addition verbose logging

@phymbert phymbert changed the title WIP server: tests: add truncated prompt tests, better kv cache size server: tests: add truncated prompt tests, better kv cache size Mar 8, 2024
@phymbert phymbert requested a review from ggerganov March 8, 2024 17:13
@phymbert phymbert marked this pull request as ready for review March 8, 2024 17:14
@phymbert phymbert requested a review from ngxson March 8, 2024 17:14
@ggerganov ggerganov merged commit fd72d2d into master Mar 9, 2024
@ggerganov ggerganov deleted the hp/server/tests/better-tests-config branch March 9, 2024 09:30
hazelnutcloud pushed a commit to hazelnutcloud/llama.cpp that referenced this pull request Mar 10, 2024
…-org#5933)

* server: tests: add truncated prompt tests, better size

* server, tests : update regex

---------

Co-authored-by: Georgi Gerganov <[email protected]>
NeoZhangJianyu pushed a commit to NeoZhangJianyu/llama.cpp that referenced this pull request Mar 12, 2024
…-org#5933)

* server: tests: add truncated prompt tests, better size

* server, tests : update regex

---------

Co-authored-by: Georgi Gerganov <[email protected]>
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this pull request Mar 13, 2024
…-org#5933)

* server: tests: add truncated prompt tests, better size

* server, tests : update regex

---------

Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants