Skip to content

awq-py : remove #5768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggerganov merged 1 commit into from
Feb 28, 2024
Merged

awq-py : remove #5768

ggerganov merged 1 commit into from
Feb 28, 2024

Conversation

@ggerganov
Copy link
Member

@ggerganov ggerganov commented Feb 28, 2024

I think this functionality never ended up being used, plus I think GGUF support was at some point implemented in the OG repo. So I think there is no reason to keep the code around

@ggerganov ggerganov merged commit 78aacf3 into master Feb 28, 2024
@ggerganov ggerganov deleted the gg/remove-awq branch February 28, 2024 15:36
@wilderfield
Copy link

wilderfield commented Mar 5, 2024

@ggerganov looks like the functionality was referenced by convert.py ?
https://github.com/ggerganov/llama.cpp/blob/652ca2bded3c818320d92c70d2b67f64bdbff5e5/convert.py#L1395-L1407

I'm a bit confused now, does this repo support quantizing models with AWQ

ggerganov added a commit that referenced this pull request Mar 6, 2024
@ggerganov
convert : remove AWQ remnants (#5768)
1e35d61
@ggerganov
Copy link
Member Author

ggerganov commented Mar 6, 2024

I just removed the leftovers from convert.py

llama.cpp does not provide AWQ quantization functionality. I believe there was work in the AWQ repos to add support for generating GGUF files directly which in turn are compatible with llama.cpp

@wilderfield
Copy link

wilderfield commented Mar 6, 2024

Thanks @ggerganov. PS, I really want to know whats in your .vimrc.

@ggerganov
Copy link
Member Author

ggerganov commented Mar 6, 2024

It's a bit of a mess, but here it is: https://github.com/ggerganov/ggterm

hazelnutcloud pushed a commit to hazelnutcloud/llama.cpp that referenced this pull request Mar 10, 2024
@ggerganov @hazelnutcloud
convert : remove AWQ remnants (ggml-org#5768)
1f745cd
NeoZhangJianyu pushed a commit to NeoZhangJianyu/llama.cpp that referenced this pull request Mar 12, 2024
@ggerganov @NeoZhangJianyu
convert : remove AWQ remnants (ggml-org#5768)
4a1d950
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this pull request Mar 13, 2024
@ggerganov @jordankanter
awq-py : remove (ggml-org#5768)
2ad8da2
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this pull request Mar 13, 2024
@ggerganov @jordankanter
convert : remove AWQ remnants (ggml-org#5768)
c441445
@hanasay hanasay mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggerganov @wilderfield