Vulkan Fixes #5223
Merged
Vulkan Fixes #5223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
approved these changes
Jan 30, 2024
ggerganov
approved these changes
Jan 30, 2024
Contributor
|
It doesn't seem to fix #5217. It still behaves pretty much the same. |
Collaborator
Author
Really? I tried interactive with your commands and it was fine. |
Contributor
Ah that's very strange then. Maybe it's a GPU architecture-dependant thing, or something is broken with my hardware... |
… amdvlk Co-authored-by: Engininja2 <[email protected]>
Contributor
|
It's fixed now! Thank you. |
Contributor
|
F16 is working now. Just needs some optimization. CPU is much faster. I'm just happy that it's not crashing anymore. Thank you @0cc4m. |
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Feb 3, 2024
* Fix Vulkan F16 models * Fix Vulkan context shift crash * Add Vulkan to common.cpp dump_non_result_info_yaml function * Fix bug in Vulkan CPY op * Fix small matrix multiplication errors in AMD GPUs on Windows or with amdvlk Co-authored-by: Engininja2 <[email protected]> --------- Co-authored-by: Engininja2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes for bugs I had missed during development. And I had missed putting Vulkan into the common.cpp dump alongside the other backends.
Fixes #5179
Fixes #5203
Fixes #5217