Skip to content

llama.h: add missing struct keyword for C compat in callback type #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggerganov merged 1 commit into from
Aug 28, 2023
Merged

llama.h: add missing struct keyword for C compat in callback type #2847

ggerganov merged 1 commit into from
Aug 28, 2023

Conversation

@igarnier
Copy link
Contributor

@igarnier igarnier commented Aug 28, 2023

Fixes C compatibility (Tested with gcc 11.3.0 on linux)

@cebtenzzre
Copy link
Collaborator

cebtenzzre commented Aug 28, 2023 •
edited
Loading

We're getting a lot of these PRs lately. Maybe we could set up CI to run gcc -xc -c llama.h -o /dev/null to check for C compliance?

@igarnier
Copy link
Contributor Author

igarnier commented Aug 28, 2023

A CI would be nice, or perhaps just a dummy target in the Makefile?

@cebtenzzre cebtenzzre mentioned this pull request Aug 28, 2023
Merged
@ggerganov ggerganov merged commit dd0dc36 into ggml-org:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igarnier @cebtenzzre @ggerganov