Fix convert-llama-ggmlv3-to-gguf.py vocab conversion #2698
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting without metadata, the hex value for bytes entries weren't 0 padded to 2 digits.
Contributor
Author
|
@SlyEcho Could you please give this fix a try and approve if it works for you? Any model converted without the metadata should be affected. I'd like to get the fix merged as soon as possible before more people have issues. edit: Confirmed to work, just needs approval. |
klosax
approved these changes
Aug 22, 2023
Contributor
|
Have not tested myself, but seems to work? |
Contributor
|
Yes, it works. FYI it was one of the files from OpenLLaMA 3B v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting without metadata, the hex values for bytes entries weren't 0 padded to 2 digits. (The llama.cpp changes in #2668 made handling more strict, though my output was always wrong.)
Closes #2697