Skip to content

fix(common): fix fail to run TranslateGemma#20956

Open
hans00 wants to merge 2 commits intoggml-org:masterfrom
hans00:fix-message-extra-params
Open

fix(common): fix fail to run TranslateGemma#20956
hans00 wants to merge 2 commits intoggml-org:masterfrom
hans00:fix-message-extra-params

Conversation

@hans00
Copy link
Copy Markdown

@hans00 hans00 commented Mar 24, 2026

Overview

  • Support extra fields for content part.
  • Ignore template verify when enable --skip-chat-parsing

fix #20305

Additional information

common_chat_msgs_parse_oaicompat will ignore everything except type and text that --skip-chat-parsing is not enough for TranslateGemma

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: Yes, use Claude Code to find the bug and human decide how to fix

@hans00 hans00 changed the title feat(common): support extra fields for content parts fix(common): fix fail to run TranslateGemma Mar 24, 2026
@pwilkin
Copy link
Copy Markdown
Member

pwilkin commented Mar 24, 2026

@ngxson @CISC I guess reviewer assignments are a bit busted now, so you might want to take a look at this.

@thermatk
Copy link
Copy Markdown

I have applied the patch and it didn't change the outcome, still failing to load

[58573] srv          init: init: chat template parsing error: 
[58573] ------------
[58573] While executing CallExpression at line 601, column 31 in source:
[58573] ... != 1 -%}↵            {{ raise_exception(↵                "User role must provid...
[58573]                                            ^
[58573] Error: Jinja Exception: User role must provide `content` as an iterable with exactly one item. That item must be a `mapping(type:'text' | 'image', source_lang_code:string, target_lang_code:string, text:string | none, image:string | none)`.
[58573] srv          init: init: please consider disabling jinja via --no-jinja, or use a custom chat template via --chat-template
[58573] srv          init: init: for example: --no-jinja --chat-template chatml
[58573] srv    operator(): operator(): cleaning up before exit...
[58573] main: exiting due to model loading error
srv    operator(): instance name=translategemma-12b-ENgb2DE exited with status 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eval bug: Jinja Template Parsing Error in TranslateGemma

3 participants