Skip to content

preset: handle negated arg, reverse the meaning if needed #18041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ngxson merged 1 commit into from
Dec 14, 2025
Merged

preset: handle negated arg, reverse the meaning if needed #18041

ngxson merged 1 commit into from
Dec 14, 2025
+22 −2

Conversation

@ngxson
Copy link
Collaborator

@ngxson ngxson commented Dec 14, 2025

Fix #18038

Should work on all these cases:

mmap = 0 --> disable mmap
mmap = 1 --> enable mmap
no-mmap = 0 --> enable mmap
no-mmap = 1 --> disable mmap

@ngxson ngxson mentioned this pull request Dec 14, 2025
Closed
@ngxson ngxson merged commit 5239229 into master Dec 14, 2025
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CISC CISC CISC approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misc. bug: "--models-preset config.ini" doesn't accept the --no-mmap argument

3 participants

@ngxson @CISC