This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Update wgpu to the new render pipeline descriptor API#734
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Jan 30, 2021
Merged
Update wgpu to the new render pipeline descriptor API#734bors[bot] merged 1 commit intogfx-rs:masterfrom
bors[bot] merged 1 commit intogfx-rs:masterfrom
Conversation
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is an autogenerated code review.
Checker summary (by rust_clippy):
The tool has found 1 warnings, 6 errors.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
There was a problem hiding this comment.
This is an autogenerated code review.
Checker summary (by rust_clippy):
The tool has found 1 warnings, 6 errors.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
8 tasks
grovesNL
approved these changes
Jan 30, 2021
Collaborator
grovesNL
left a comment
grovesNL
left a comment
There was a problem hiding this comment.
Looks great 👍 The examples look really nice with the new API!
Member
Author
|
Thank you for reviewing! |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAJOR API BREAKING CHANGE
Gets us gfx-rs/wgpu#1176