[d3d12] get vertex_index & instance_index builtins working for indirect draws#7535
Merged
teoxoy merged 4 commits intogfx-rs:trunkfrom Apr 15, 2025
Merged
[d3d12] get vertex_index & instance_index builtins working for indirect draws#7535teoxoy merged 4 commits intogfx-rs:trunkfrom
vertex_index & instance_index builtins working for indirect draws#7535teoxoy merged 4 commits intogfx-rs:trunkfrom
Conversation
teoxoy
force-pushed
the
indirect-draw-builtins
branch
from
77fa219 to
d1d3df7
Compare
ErichDonGubler
approved these changes
Apr 14, 2025
Member
ErichDonGubler
left a comment
ErichDonGubler
left a comment
There was a problem hiding this comment.
Approving conditional on resolution of questions.
teoxoy
force-pushed
the
indirect-draw-builtins
branch
from
d1d3df7 to
ac04c6e
Compare
…_FIRST_VALUE_IN_INDIRECT_DRAW`
We are aware of this issue, I don't know why the example doesn't fail on trunk though...
teoxoy
force-pushed
the
indirect-draw-builtins
branch
from
ac04c6e to
ac1a413
Compare
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Closes #2471
Description
Gets the
vertex_index&instance_indexbuiltins working for indirect draws by updating the existing root constants (using the validation shader; same strategy as in #5730).Testing
Existing
wgpu_gpu::vertex_indicestest.Squash or Rebase?
Rebase