Implement Features::RG11B10UFLOAT_RENDERABLE#3701
Merged
teoxoy merged 2 commits intogfx-rs:trunkfrom Apr 19, 2023
Merged
Conversation
teoxoy
requested changes
Apr 18, 2023
Member
teoxoy
left a comment
teoxoy
left a comment
There was a problem hiding this comment.
Besides the comment it looks great! Thanks!
3 tasks
Member
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
After comment is addressed secondary g2g :)
Member
|
@jinleili would you like to also reference this PR and your username in the existing changelog entry? |
Contributor
Author
I prefer not to reference my username in the changelog. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
#3689
resolves #3268
Testing
Tested locally