add feature RG11B10UFLOAT_RENDERABLE on webgpu#3689
Merged
nical merged 2 commits intogfx-rs:trunkfrom Apr 14, 2023
Merged
Conversation
mockersf
force-pushed
the
enable-feature-RG11B10UFLOAT_RENDERABLE
branch
from
6d34f07 to
ad5e825
Compare
| /// - Metal | ||
| /// | ||
| /// This is a web and native feature. | ||
| const RG11B10UFLOAT_RENDERABLE = 1 << 23; |
Member
There was a problem hiding this comment.
This is already working because bevy uses adapter specific texture format features. If a user isn't, it needs to both advertise this feature, and change how we check the flags for texture features
Member
Contributor
There was a problem hiding this comment.
As wgpu 0.16 is going to be released in the next few days, if there is a need, I am happy to complete this part of the code.
Contributor
Author
There was a problem hiding this comment.
I started looking into this, I will open the PR now but I'm trying to find if there are conditions to check before adding it to DX12/Vulkan/Metal
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Description
Add feature
RG11B10UFLOAT_RENDERABLEon webgpu. I don't think this needs anything else added as, at least for Bevy, it was already working for metal/dx/vulkanTesting
Rendered bloom examples from Bevy on webgpu and metal that use this texture format
webgpu:
metal:
