vk: fix surface view formats validation error#3432
Merged
cwfitzgerald merged 3 commits intogfx-rs:masterfrom Feb 9, 2023
Merged
vk: fix surface view formats validation error#3432cwfitzgerald merged 3 commits intogfx-rs:masterfrom
cwfitzgerald merged 3 commits intogfx-rs:masterfrom
Conversation
cwfitzgerald
approved these changes
Feb 1, 2023
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Looks good - can that function be made pub(super) so you can do the conversion early?
Contributor
Author
|
I think it cannot, because |
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Feb 9, 2023
Co-authored-by: Connor Fitzgerald <[email protected]>
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Feb 9, 2023
Co-authored-by: Connor Fitzgerald <[email protected]>
cwfitzgerald
added a commit
that referenced
this pull request
Feb 9, 2023
Co-authored-by: Connor Fitzgerald <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
From Matrix:
Description
Maybe it's better to set the type of the
view_formatsfield inhal/vk/TexturetoVec<vk::Format>, but I can't callprivate_caps.map_texture_format()instance function intexture_from_raw()to implement format mapping.Testing
Tested locally