Skip to content

winit 0.27 Update and raw-window-handle 0.5#2918

Merged
cwfitzgerald merged 13 commits intogfx-rs:masterfrom
wyatt-herkamp:master
Aug 4, 2022
Merged

winit 0.27 Update and raw-window-handle 0.5#2918
cwfitzgerald merged 13 commits intogfx-rs:masterfrom
wyatt-herkamp:master

Conversation

@wyatt-herkamp
Copy link
Copy Markdown
Contributor

@wyatt-herkamp wyatt-herkamp commented Jul 27, 2022 •
edited by cwfitzgerald
Loading

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Closes #2928

Description
Winit released 0.27 today. With this decoupling Display and Window Handles rust-windowing/raw-window-handle#92

If I am within the Window Handle match block I get the Display handle via an if let statement returning with an Error if the type does not match.
Testing
Ran the examples on a Windows 11 environment x86 AMD/Nvidia setup

@wyatt-herkamp wyatt-herkamp marked this pull request as ready for review July 27, 2022 00:11
@wyatt-herkamp wyatt-herkamp changed the title [WIP] winit 0.27 Update and raw-window-handle 0.5 winit 0.27 Update and raw-window-handle 0.5 Jul 27, 2022
@dhardy
Copy link
Copy Markdown
Contributor

dhardy commented Jul 27, 2022

Tested on Fedora / 5.18.10-100.fc35.x86_64 / RX570: examples work except

  • mipmap which requires feature wgpu::Features::WRITE_TIMESTAMP_INSIDE_PASSES to be enabled
  • conservative-raster (doesn't work on my GPU)

@parasyte parasyte mentioned this pull request Jul 29, 2022
Closed
@terrarier2111 terrarier2111 mentioned this pull request Jul 31, 2022
Closed
@wyatt-herkamp
Copy link
Copy Markdown
Contributor Author

wyatt-herkamp commented Jul 31, 2022 •
edited
Loading

This bug will be fixed in rust-lang/rust#97791 that comes in 1.63

@cwfitzgerald
Copy link
Copy Markdown
Member

cwfitzgerald commented Jul 31, 2022

So this would bump our MSRV to 1.63?

@wyatt-herkamp
Copy link
Copy Markdown
Contributor Author

wyatt-herkamp commented Jul 31, 2022

So this would bump our MSRV to 1.63?

Apparently so.

@cwfitzgerald
Copy link
Copy Markdown
Member

cwfitzgerald commented Jul 31, 2022

Could you have this PR bump the MSRV?

@Aceeri Aceeri mentioned this pull request Aug 1, 2022
Closed
@emilk emilk mentioned this pull request Aug 1, 2022
Closed
@emilk
Copy link
Copy Markdown
Contributor

emilk commented Aug 1, 2022

winit 0.27.1 has been released which lowers the MSRV to 1.57.0: https://github.com/rust-windowing/winit/blob/master/CHANGELOG.md#0271-2022-07-30

@wyatt-herkamp
Copy link
Copy Markdown
Contributor Author

wyatt-herkamp commented Aug 1, 2022

winit 0.27.1 has been released which lowers the MSRV to 1.57.0: rust-windowing/winit@master/CHANGELOG.md#0271-2022-07-30

Alright all builds were able to run https://github.com/wyatt-herkamp/wgpu/actions/runs/2774303424

@hannobraun hannobraun mentioned this pull request Aug 1, 2022
Closed
emilk
emilk reviewed Aug 1, 2022
View reviewed changes
@CatCode79 CatCode79 mentioned this pull request Aug 1, 2022
Closed
cwfitzgerald
cwfitzgerald requested changes Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, some comments

cwfitzgerald
cwfitzgerald reviewed Aug 1, 2022
View reviewed changes
cwfitzgerald
cwfitzgerald reviewed Aug 1, 2022
View reviewed changes
cwfitzgerald
cwfitzgerald approved these changes Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@cwfitzgerald
Copy link
Copy Markdown
Member

cwfitzgerald commented Aug 2, 2022

Enscripten CI is mad

@wyatt-herkamp
Copy link
Copy Markdown
Contributor Author

wyatt-herkamp commented Aug 2, 2022

Enscripten CI is mad

It doesn't like importing RawDisplayHandle as Rdh because when the one feature is not enabled the import is not used.

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) August 4, 2022 06:06
@cwfitzgerald cwfitzgerald merged commit f7526ae into gfx-rs:master Aug 4, 2022
@emilk
Copy link
Copy Markdown
Contributor

emilk commented Aug 4, 2022

🥳

Question: what is the release schedule for wgpu? i.e. when can I expect this to be released?

@cwfitzgerald
Copy link
Copy Markdown
Member

cwfitzgerald commented Aug 4, 2022

Currently we're on a loose 90 day schedule, without making up for lost time so next release will be late September - the calculated date is listed on the milestone for 0.14

This was referenced Aug 10, 2022
Merged
Closed
@cwfitzgerald cwfitzgerald mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

+1 more reviewer

@emilk emilk emilk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for raw-window-handle 0.5

4 participants

@wyatt-herkamp @dhardy @cwfitzgerald @emilk