fix compilation on wasm32-unknown-unknown without webgl feature#2355
Merged
kvark merged 1 commit intogfx-rs:masterfrom Jan 4, 2022
Merged
fix compilation on wasm32-unknown-unknown without webgl feature#2355kvark merged 1 commit intogfx-rs:masterfrom
webgl feature#2355kvark merged 1 commit intogfx-rs:masterfrom
Conversation
kvark
approved these changes
Jan 4, 2022
Member
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
whoa, this isn't checked on CI at the moment?
cwfitzgerald
added
the
PR: needs back-porting
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jan 21, 2022
kvark
pushed a commit
that referenced
this pull request
Jan 21, 2022
kvark
removed
the
PR: needs back-porting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When compiling for the target
wasm32-unknown-unknownwithout thewebglfeature enabled, the code had some errors.Testing
The code compiles again.
Open questions
The
back::wgsl::write_stringnow acceptsWriterFlagswhich contain theEXPLICIT_TYPESoption. Should it be enabled?