feedback iter

gf2121 · gf2121 · commit 8ec993032c17 · 2025-05-26T04:06:37.000+08:00
diff --git a/lucene/core/src/java/org/apache/lucene/search/BatchScoreBulkScorer.java b/lucene/core/src/java/org/apache/lucene/search/BatchScoreBulkScorer.java
diff --git a/lucene/core/src/java/org/apache/lucene/search/TermQuery.java b/lucene/core/src/java/org/apache/lucene/search/TermQuery.java
@@ -173,7 +173,7 @@ public BulkScorer bulkScorer() throws IOException {
             return ConstantScoreScorerSupplier.fromIterator(iterator, 0f, scoreMode, maxDoc)
                 .bulkScorer();
           }
-          return new BatchScoreBulkScorer(get(Long.MAX_VALUE));
+          return new DefaultBulkScorer(get(Long.MAX_VALUE), scoreMode);
         }
 
         @Override
diff --git a/lucene/core/src/java/org/apache/lucene/search/Weight.java b/lucene/core/src/java/org/apache/lucene/search/Weight.java
@@ -231,16 +231,24 @@ protected static class DefaultBulkScorer extends BulkScorer {
     private final Scorer scorer;
     private final DocIdSetIterator iterator;
     private final TwoPhaseIterator twoPhase;
+    private final ScoreMode scoreMode;
+    private DocAndScoreBuffer buffer;
 
     /** Sole constructor. */
     public DefaultBulkScorer(Scorer scorer) {
+      this(scorer, null);
+    }
+
+    /** Sole constructor. */
+    public DefaultBulkScorer(Scorer scorer, ScoreMode scoreMode) {
       this.scorer = Objects.requireNonNull(scorer);
       this.twoPhase = scorer.twoPhaseIterator();
       if (twoPhase == null) {
         this.iterator = scorer.iterator();
       } else {
         this.iterator = twoPhase.approximation();
       }
+      this.scoreMode = scoreMode;
     }
 
     @Override
@@ -251,9 +259,14 @@ public long cost() {
     @Override
     public int score(LeafCollector collector, Bits acceptDocs, int min, int max)
         throws IOException {
-      collector.setScorer(scorer);
       DocIdSetIterator competitiveIterator = collector.competitiveIterator();
 
+      if (scoreMode != null && scoreMode.needsScores() && competitiveIterator == null) {
+        return batchScore(collector, acceptDocs, min, max);
+      }
+
+      collector.setScorer(scorer);
+
       if (competitiveIterator != null) {
         if (competitiveIterator.docID() > min) {
           min = competitiveIterator.docID();
@@ -290,6 +303,35 @@ public int score(LeafCollector collector, Bits acceptDocs, int min, int max)
       return iterator.docID();
     }
 
+    private int batchScore(LeafCollector collector, Bits acceptDocs, int min, int max)
+        throws IOException {
+      if (buffer == null) {
+        buffer = new DocAndScoreBuffer();
+      }
+
+      SimpleScorable scorable = new SimpleScorable();
+      collector.setScorer(scorable);
+      scorer.setMinCompetitiveScore(scorable.minCompetitiveScore);
+
+      if (scorer.docID() < min) {
+        scorer.iterator().advance(min);
+      }
+
+      for (scorer.nextDocsAndScores(max, acceptDocs, buffer);
+          buffer.size > 0;
+          scorer.nextDocsAndScores(max, acceptDocs, buffer)) {
+        for (int i = 0, size = buffer.size; i < size; i++) {
+          float score = scorable.score = buffer.scores[i];
+          if (score >= scorable.minCompetitiveScore) {
+            collector.collect(buffer.docs[i]);
+          }
+        }
+        scorer.setMinCompetitiveScore(scorable.minCompetitiveScore);
+      }
+
+      return scorer.docID();
+    }
+
     private static void scoreIterator(
         LeafCollector collector, Bits acceptDocs, DocIdSetIterator iterator, int max)
         throws IOException {
diff --git a/lucene/core/src/test/org/apache/lucene/search/TestBooleanScorer.java b/lucene/core/src/test/org/apache/lucene/search/TestBooleanScorer.java
@@ -201,7 +201,7 @@ public void testOptimizeTopLevelClauseOrNull() throws IOException {
     weight = searcher.createWeight(searcher.rewrite(query), ScoreMode.COMPLETE, 1);
     ss = weight.scorerSupplier(ctx);
     scorer = ((BooleanScorerSupplier) ss).booleanScorer();
-    assertThat(scorer, instanceOf(BatchScoreBulkScorer.class)); // term scorer
+    assertThat(scorer, instanceOf(DefaultBulkScorer.class)); // term scorer
 
     w.close();
     reader.close();

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ public BulkScorer bulkScorer() throws IOException {`
`173`	`173`	`return ConstantScoreScorerSupplier.fromIterator(iterator, 0f, scoreMode, maxDoc)`
`174`	`174`	`.bulkScorer();`
`175`	`175`	`}`
`176`		`- return new BatchScoreBulkScorer(get(Long.MAX_VALUE));`
	`176`	`+ return new DefaultBulkScorer(get(Long.MAX_VALUE), scoreMode);`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`@Override`