ci(release): Add npm pack step for Craft npm publishing #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Ui
Other
Documentation 📚Website
Other
Build / dependencies / internal 🔧CraftRelease
Other
Other
🤖 This preview updates automatically when you update the PR. |
BYK
changed the title
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Craft's npm target looks for .tgz files in the artifacts. Add a pnpm pack step to create the package tarball. The .tgz is stored in a separate 'npm-package' artifact to avoid changing the structure of 'built-packages' which E2E tests depend on (uploading multiple paths with different ancestors would nest the dist/ folder).
BYK
force-pushed
the
fix/craft-npm-pack
branch
from
9f6763c to
d16c26d
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The release failed with:
Craft's npm target looks for
.tgzfiles (created bynpm pack) in the artifacts, but thebuilt-packagesartifact only contained thedist/directory contents.Solution
Add a
pnpm packstep before uploading thebuilt-packagesartifact to create the package tarball that Craft expects for npm publishing.