Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jan 12, 2026

Summary

Fix the release workflow which was failing with:

bash: scripts/bump-version.sh: line 19: pnpm: command not found

Changes

Added pnpm and Node.js setup steps to the release workflow before Craft runs the preReleaseCommand. This ensures pnpm is available when bump-version.sh executes.

The setup steps match those used in build.yml:

  • pnpm/action-setup@v4 - reads pnpm version from packageManager in package.json
  • actions/setup-node@v6 - reads Node version from the volta section in package.json

The release workflow was failing because the preReleaseCommand in .craft.yml
runs bump-version.sh which requires pnpm, but pnpm was not available in the
GitHub Actions environment.

Added the same pnpm and Node.js setup steps used in build.yml to ensure
pnpm is available when Craft executes the version bump script.
@vercel
Copy link

vercel bot commented Jan 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
spotlightjs Ready Ready Preview, Comment Jan 12, 2026 9:47pm

@BYK BYK deployed to Preview January 12, 2026 21:47 — with GitHub Actions Active
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Added a dynamic header for dragbar by MathurAditya724 in #1223
  • Better error message display by MathurAditya724 in #1222

Bug Fixes 🐛

Ui

  • Add validation guards to WebVitalsDetail to prevent crashes by BYK in #1243
  • Handle null/undefined span.description safely by BYK in #1239

Other

  • (sentry) Upload and use source maps for all build targets by BYK in #1241
  • Improve EADDRINUSE error handling and UX by BYK in #1240
  • Updated react-router-dom version to latest by MathurAditya724 in #1245
  • Add error handling for base64 decode operations by BYK in #1237
  • Silence non-fixable Sentry errors by BYK in #1242
  • Add null safety to WebVitals comparators by BYK in #1238
  • Add null check for itemHeader in processEnvelope by BYK in #1233
  • Shiki theme in light mode by MathurAditya724 in #1230

Documentation 📚

Website

  • Add feedback note for Spotlight SDK in documentation by MathurAditya724 in #1228
  • Add NextJS guide by betegon in #1129

Other

  • Add section for the spotlight sdk by MathurAditya724 in #1227

Build / dependencies / internal 🔧

Craft

  • Fix Craft traget ids by BYK in #1248
  • Bump craft version to fix releases by BYK in #1246

Release

  • Add pnpm and Node.js setup to release workflow by BYK in #1247
  • Add pnpm and Node.js setup to release workflow by BYK in #1247
  • Migrate to Craft by betegon in #1232

Other

  • (deps) Bump @modelcontextprotocol/sdk from 1.24.3 to 1.25.2 by dependabot in #1234
  • Add workflow to notify issues on release by betegon in #1236
  • Using the param instead of calling a function by MathurAditya724 in #1224

Other

  • Node 24.x support by BYK in #1235
  • Vite windows deny bypass by BYK in #1229
  • Qs security vulnerability fix by BYK in #1226
  • Dependency security updates by BYK in #1225
  • Event origin badges ui by BYK in #1221

🤖 This preview updates automatically when you update the PR.

@BYK BYK marked this pull request as ready for review January 12, 2026 21:47
@BYK BYK enabled auto-merge (squash) January 12, 2026 21:47
@BYK BYK requested a review from betegon January 12, 2026 21:47
@BYK BYK merged commit c2b7464 into main Jan 12, 2026
22 checks passed
@BYK BYK deleted the fix/release-workflow-pnpm branch January 12, 2026 21:53
@BYK BYK changed the title fix(ci): Add pnpm and Node.js setup to release workflow ci(release): Add pnpm and Node.js setup to release workflow Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants