Skip to content

fix: improve EADDRINUSE error handling and UX #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BYK merged 2 commits into from
Jan 10, 2026
Merged

fix: improve EADDRINUSE error handling and UX #1240

BYK merged 2 commits into from
Jan 10, 2026

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jan 8, 2026 •
edited
Loading

Problem

When port 8969 is in use, the retry logic silently retries and can still fail after 3 attempts with an unhandled rejection, providing poor user experience.

Solution

  • Enhanced retry logging: Shows attempt number (e.g., 'retrying (1/3)') so users know progress
  • Custom PortInUseError: Creates descriptive error with actionable guidance after max retries
  • Graceful CLI handling: Catches PortInUseError specifically, logs it nicely, and exits gracefully without sending to Sentry
  • Preserves existing behavior: Electron and other error types continue to work as before

Changes

  • Added PortInUseError class in main.ts with helpful error message
  • Updated retry logging to show attempt progress
  • Added error handling in CLI server handler for graceful exit

Fixes SPOTLIGHT-7Q
Fixes SPOTLIGHT-8C
Fixes SPOTLIGHT-9A

@BYK
fix: improve EADDRINUSE error handling and UX
6824ce0 
Improve user experience when port 8969 is already in use:

- Add retry attempt tracking in log messages (e.g., 'retrying (1/3)')
- Create PortInUseError class with actionable error message
- Handle PortInUseError gracefully in CLI with clear error output
- Prevent PortInUseError from being sent to Sentry in CLI context

Fixes SPOTLIGHT-7Q/8C/9A
@vercel
Copy link

vercel bot commented Jan 8, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
spotlightjs Skipped Skipped Jan 8, 2026 1:33am

@BYK BYK deployed to Preview January 8, 2026 00:48 — with GitHub Actions Active
@BYK BYK requested a review from betegon January 8, 2026 00:48
@BYK BYK marked this pull request as ready for review January 8, 2026 00:48
cursor[bot]
cursor bot reviewed Jan 8, 2026
View reviewed changes
@BYK
fix: address PR review comments
7305180 
- Fix retry log order: check retries > MAX_RETRIES before logging to avoid showing (4/3)
- Add PortInUseError handling to tail command handler
- Fix linting: use single template literal instead of string concatenation
@BYK BYK deployed to Preview January 8, 2026 01:33 — with GitHub Actions Active
@BYK BYK merged commit de8559c into main Jan 10, 2026
20 checks passed
@BYK BYK deleted the fix/eaddrinuse-ux-improvement branch January 10, 2026 00:59
This was referenced Jan 12, 2026
Merged
Merged
Merged
This was referenced Jan 12, 2026
Closed
Closed
This was referenced Jan 12, 2026
Merged
Merged
@sentry-release-bot sentry-release-bot bot mentioned this pull request Jan 12, 2026
Closed
4 tasks
@github-actions github-actions bot mentioned this pull request Jan 12, 2026
Merged
@sentry-release-bot sentry-release-bot bot mentioned this pull request Jan 13, 2026
Closed
4 tasks
@github-actions github-actions bot mentioned this pull request Jan 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@betegon betegon betegon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BYK @betegon