fix: add null check for itemHeader in processEnvelope #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SPOTLIGHT-9W Add null check for itemHeader after parsing to prevent crashes when parseJSONFromBuffer returns null for malformed envelope data. This matches the existing pattern used for envelope header handling.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Update getParsedEnvelope return type to ParsedEnvelope | null and add null checks in callers that were missing them: - formatters/md/errors.ts - formatters/md/logs.ts - messageBuffer.ts filter functions
This was referenced Jan 8, 2026
This was referenced Jan 12, 2026
This was referenced Jan 12, 2026
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add null check for
itemHeaderafter parsing to prevent crashes whenparseJSONFromBufferreturns null for malformed envelope data.Problem
In
processEnvelope.ts, accessingitemHeader.lengthwithout a null check causes crashes when parsing fails:Solution
Add null check matching the existing pattern used for envelope header handling (lines 42-46).
Fixes SPOTLIGHT-9W