fix(ui): Correct flamechart tree ordering to build from root to leaf #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The profile tree was being built with a double-reversal bug: 1. profileProcessor.ts reverses stacks (root at index 0) 2. profileTree.ts iterated in reverse again, starting from leaf Changed tree building to iterate forward through the already-reversed stacks, correctly building from root frames to leaf frames. Fixes #1100
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
pushed a commit
that referenced
this pull request
Dec 13, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/[email protected] ### Minor Changes - Add `--open` / `-o` CLI flag to automatically open the Spotlight dashboard in your default browser when starting the sidecar ([#1200](#1200)) ### Patch Changes - Fixed flamechart tree building to iterate from root to leaf frames, resolving fragmented visualization ([#1201](#1201)) - shifted electron dependencies to dev dependencies as there were getting installed with npx for spotlight run ([#1184](#1184)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profile tree was being built with a double-reversal bug:
Changed tree building to iterate forward through the already-reversed
stacks, correctly building from root frames to leaf frames.
Fixes #1100