fix: shifted electron dependencies to dev dependencies #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MathurAditya724
had a problem deploying
to
Preview
GitHub Actions
Failure
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
111
to
117
| "react-dom": "catalog:", | ||
| "react-router-dom": "^6.26.2", | ||
| "rollup-plugin-sourcemaps2": "^0.4.1", | ||
| "semver": "^7.7.3", | ||
| "shiki": "^3.13.0", | ||
| "sql-formatter": "^12.2.4", | ||
| "tailwind-merge": "^3.3.0", |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
MathurAditya724
had a problem deploying
to
Preview
GitHub Actions
Failure
Comment on lines
47
to
54
| formats: ["es"], | ||
| }, | ||
| rollupOptions: { | ||
| external: [ | ||
| // Externalize all Node.js built-ins | ||
| /^node:.*/, | ||
| // Externalize all dependencies | ||
| "@hono/mcp", | ||
| "@hono/node-server", | ||
| "@jridgewell/trace-mapping", | ||
| "@modelcontextprotocol/sdk", | ||
| "@sentry/core", | ||
| "@sentry/electron", | ||
| "@sentry/node", | ||
| "chalk", | ||
| "electron-store", | ||
| "electron-updater", | ||
| "eventsource", | ||
| "fast-fuzzy", | ||
| "hono", | ||
| "import-meta-resolve", | ||
| "launch-editor", | ||
| "logfmt", | ||
| "mcp-proxy", | ||
| "semver", | ||
| "uuidv7", | ||
| "yaml", | ||
| "zod", | ||
| ], | ||
| // Externalize all Node.js built-ins | ||
| external: [/^node:.*/], | ||
| output: { | ||
| entryFileNames: "[name].js", | ||
| chunkFileNames: "[name].js", |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MathurAditya724
had a problem deploying
to
Preview
GitHub Actions
Error
MathurAditya724
had a problem deploying
to
Preview
GitHub Actions
Error
MathurAditya724
changed the title
Comment on lines
78
to
84
| "@radix-ui/react-slot": "^1.2.3", | ||
| "@radix-ui/react-tooltip": "^1.2.7", | ||
| "@sentry/browser": "^10.26.0", | ||
| "@sentry/electron": "^7.3.0", | ||
| "@sentry/react": "^10.26.0", | ||
| "@sentry/vite-plugin": "^2.22.5", | ||
| "@shikijs/transformers": "^3.13.0", |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| '@sentry/core': | ||
| specifier: ^10 | ||
| version: 10.28.0 | ||
| version: 10.5.0 |
There was a problem hiding this comment.
Bug: Sentry core downgraded causing version mismatch with node
The @sentry/core package was downgraded from version 10.28.0 to 10.5.0 in the catalog, while @sentry/node remains at 10.28.0. This creates a version mismatch between related Sentry packages that are designed to work together at the same version. The @sentry/node package internally depends on @sentry/core and may experience compatibility issues or missing type definitions (like SerializedLog) when these versions don't match. This appears to be an unintentional side effect of regenerating the lockfile rather than part of the intended dependency restructuring.
Additional Locations (1)
Comment on lines
104
to
111
| "dotenv": "^16.4.5", | ||
| "electron": "^35.7.5", | ||
| "electron-builder": "^24.13.3", | ||
| "electron-store": "^10.0.1", | ||
| "electron-updater": "^6.6.2", | ||
| "eslint": "^8.57.1", | ||
| "eslint-plugin-react-hooks": "^4.6.2", | ||
| "eslint-plugin-react-refresh": "^0.4.12", |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Comment on lines
56
to
66
| "@modelcontextprotocol/sdk": "^1.16.0", | ||
| "@sentry/core": "catalog:", | ||
| "@sentry/electron": "^7.3.0", | ||
| "@sentry/node": "catalog:", | ||
| "anser": "^2.3.3", | ||
| "chalk": "^5.6.2", | ||
| "electron-store": "^10.0.0", | ||
| "electron-updater": "^6.3.9", | ||
| "eventsource": "^4.0.0", | ||
| "fast-fuzzy": "^1.12.0", | ||
| "hono": "^4.10.3", | ||
| "import-meta-resolve": "^4.1.0", | ||
| "launch-editor": "^2.9.1", | ||
| "logfmt": "^1.4.0", | ||
| "mcp-proxy": "^5.6.0", |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MathurAditya724
force-pushed
the
adi/fix/depen
branch
from
107da79 to
93cea70
Compare
MathurAditya724
had a problem deploying
to
Preview
GitHub Actions
Failure
BYK
reviewed
Dec 5, 2025
BYK
approved these changes
Dec 5, 2025
BYK
pushed a commit
that referenced
this pull request
Dec 13, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/[email protected] ### Minor Changes - Add `--open` / `-o` CLI flag to automatically open the Spotlight dashboard in your default browser when starting the sidecar ([#1200](#1200)) ### Patch Changes - Fixed flamechart tree building to iterate from root to leaf frames, resolving fragmented visualization ([#1201](#1201)) - shifted electron dependencies to dev dependencies as there were getting installed with npx for spotlight run ([#1184](#1184)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import-meta-resolvepackage, as it was not getting used anywhere