-
-
Notifications
You must be signed in to change notification settings - Fork 32
fix(sentry): report github-ci environment when running in CI #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this will also report GitHub CI if people start using Spotlight in CI (one of our potential future use cases). Might be better to find a few more markers to mark this as our CI.
Btw there's this for a more generic approach: https://www.npmjs.com/package/is-in-ci
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/[email protected] ### Patch Changes - Report `github-ci` environment to Sentry when running in GitHub Actions CI ([#1178](#1178)) - Fix `npx @spotlightjs/spotlight` fail ([#1181](#1181)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Detect GitHub Actions CI at runtime and report Sentry environment as
github-ciinstead ofproduction.This allows distinguishing CI test runs from actual production usage in Sentry dashboards.
CIandGITHUB_ACTIONSenvironment variablesproductionsince these env vars won't exist there