Implement compose file environment variable support #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to specify compose files via the COMPOSE_FILE environment variable. It also ensures that the COMPOSE_FILE variable is unset after use to prevent unintended side effects. Co-authored-by: burak.kaya <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: burak.kaya <[email protected]>
Co-authored-by: burak.kaya <[email protected]>
Co-authored-by: burak.kaya <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| cmdArgs = command.cmdArgs; | ||
| dockerComposeOverride = command.dockerComposeOverride; | ||
| // Always unset COMPOSE_FILE to avoid conflicts with explicit -f flags | ||
| env.COMPOSE_FILE = undefined; |
There was a problem hiding this comment.
Bug: Env Vars: undefined Becomes String, Not Unset
Setting env.COMPOSE_FILE = undefined will convert the environment variable to the string "undefined" in the spawned process instead of unsetting it. To properly unset an environment variable in Node.js, use delete env.COMPOSE_FILE instead.
| cmdArgs = command.cmdArgs; | ||
| dockerComposeOverride = command.dockerComposeOverride; | ||
| // Always unset COMPOSE_FILE to avoid conflicts with explicit -f flags | ||
| env.COMPOSE_FILE = undefined; |
There was a problem hiding this comment.
Bug: The undefined Environment Variable Trap
Setting env.COMPOSE_FILE = undefined will convert the environment variable to the string "undefined" in the spawned process instead of unsetting it. To properly unset an environment variable in Node.js, use delete env.COMPOSE_FILE instead.
Co-authored-by: burak.kaya <[email protected]>
betegon
requested changes
Nov 14, 2025
betegon
deleted the
cursor/implement-compose-file-environment-variable-support-9764
branch
betegon
added a commit
that referenced
this pull request
Dec 1, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/[email protected] ### Minor Changes - Added spotlight sdk for helping others to build on top of it ([#1140](#1140)) - Support COMPOSE_FILE environment variable for Docker Compose projects ([#1131](#1131)) - Prompt user to choose between docker compose and package.json when both are present ([#1120](#1120)) ### Patch Changes - Refactor docker compose support ([#1121](#1121)) - disable sentry in development mode ([#1143](#1143)) - **Security:** Restrict CORS origins for Sidecar to prevent unauthorized access ([#1138](#1138)) The Sidecar now only accepts requests from trusted origins: - `localhost` with any port or protocol (http/https) - `https://spotlightjs.com` and `https://*.spotlightjs.com` (HTTPS only, default port)⚠️ **Potentially Breaking:** If you were accessing the Sidecar from other origins (e.g., custom domains, non-HTTPS spotlightjs.com), those connections will now be rejected. This change improves security by preventing malicious websites from connecting to your local Sidecar instance. - Fix file capture error handling to log errors instead of crashing when SPOTLIGHT_CAPTURE is enabled ([#1142](#1142)) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Miguel Betegón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1089 (comment)
This PR implements support for the
COMPOSE_FILEenvironment variable, allowing users to specify one or more Docker Compose files via an environment variable, aligning with native Docker Compose behavior.Key changes:
COMPOSE_FILE: Spotlight now checks theCOMPOSE_FILEenvironment variable first to determine which compose files to use.COMPOSE_FILEis set, automatic detection ofdocker-compose.override.ymlis skipped, matching native Docker Compose behavior.COMPOSE_FILE(separated by:on Unix,;on Windows).COMPOSE_FILEvariable is unset in the spawned Docker Compose process to prevent conflicts with explicitly passed-fflags.