Fix(sidecar): Unknown type event error #1111
Merged
+54
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Nov 7, 2025
Member
BYK
left a comment
BYK
left a comment
There was a problem hiding this comment.
Amazing patch, thank you so much!
Comment on lines
+77
to
+80
| if (Number.isNaN(date.getTime())) { | ||
| // placeholder with same width as valid timestamp for alignment in the logs | ||
| return "??:??:??"; | ||
| } |
| const entry = registry[eventType]; | ||
| const event = payload as SentryEvent; | ||
| if (!entry.typeGuard(event)) { | ||
| logger.warn(`Skipping event: type guard failed for ${eventType} (event.type=${(event as any).type})`); |
Member
There was a problem hiding this comment.
It'd be good to dump the event using logger.debug(utils.inspect(event)) and/or sending this to Sentry for inspection
Comment on lines
+21
to
+24
| const hasValidType = !event.type || ERROR_EVENT_TYPES.has(event.type); | ||
| const hasException = Boolean((event as SentryErrorEvent).exception); | ||
| const hasMessage = Boolean((event as SentryErrorEvent).message); | ||
| return hasValidType && (hasException || hasMessage); |
Member
There was a problem hiding this comment.
Keep in mind that this version is less performant than the one you replaced as it doesn't "short circut". Might become an issue under heavy load, otherwise impact should be insignificant.
BYK
pushed a commit
that referenced
this pull request
Nov 10, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/[email protected] ### Minor Changes - Docker compose support for Spotlight run command ([#1108](#1108)) - Added support for Last-Event-Id in SSE stream ([#1104](#1104)) - Change tool names: change `.` for `_` and remove `spotlight` preffix ([#1114](#1114)) - Improved human formatter readability ([#1112](#1112)) ### Patch Changes - Fix breaking error when event type is not supported ([#1111](#1111)) - Fix SDK categorization for Next.js by using User-Agent headers to distinguish browser from server events ([#1110](#1110)) ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[[`0942c8a`](0942c8a), [`bce012e`](bce012e), [`7624030`](7624030), [`15a7f41`](15a7f41), [`13da542`](13da542), [`b3a654a`](b3a654a)]: - @spotlightjs/[email protected] - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Fix SDK categorization for Next.js by using User-Agent headers to distinguish browser from server events ([#1110](#1110)) - Updated dependencies \[[`0942c8a`](0942c8a), [`bce012e`](bce012e), [`7624030`](7624030), [`15a7f41`](15a7f41), [`13da542`](13da542), [`b3a654a`](b3a654a)]: - @spotlightjs/[email protected] - @spotlightjs/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error what was exiting the program;
This fixes it and also shows a better human output for ISO and UNIX timestamps
Before:
Now:
