Improve SDK categorization implementation #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: burak.kaya <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Co-authored-by: burak.kaya <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-authored-by: burak.kaya <[email protected]>
cursor bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
Merged commits: - b3a654a: Improve SDK categorization implementation (#1110) - 43318aa: ci: Fix notarization env var swap (#1109) Key changes from main: - Enhanced SDK categorization using multiple signals (User-Agent, runtime tags, platform, server-specific signals) for better browser vs server detection - Fixed notarization environment variables in CI - Updated formatters to use improved categorization logic Conflict resolutions: - Kept our consolidated package structure (ui/, sidecar/, electron/) - Maintained separate build configs (vite.config.ts for UI library, vite.ui.config.ts for static assets, tsc for sidecar) - Preserved path aliases and electron app description - Removed TypeScript types from bin/run.js since it's a JS file - Fixed duplicate RAW_TYPES import in envelopesSlice.ts - Added core dump files to .gitignore All SDK categorization improvements have been merged into our consolidated structure.
BYK
pushed a commit
that referenced
this pull request
Nov 10, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/[email protected] ### Minor Changes - Docker compose support for Spotlight run command ([#1108](#1108)) - Added support for Last-Event-Id in SSE stream ([#1104](#1104)) - Change tool names: change `.` for `_` and remove `spotlight` preffix ([#1114](#1114)) - Improved human formatter readability ([#1112](#1112)) ### Patch Changes - Fix breaking error when event type is not supported ([#1111](#1111)) - Fix SDK categorization for Next.js by using User-Agent headers to distinguish browser from server events ([#1110](#1110)) ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[[`0942c8a`](0942c8a), [`bce012e`](bce012e), [`7624030`](7624030), [`15a7f41`](15a7f41), [`13da542`](13da542), [`b3a654a`](b3a654a)]: - @spotlightjs/[email protected] - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Fix SDK categorization for Next.js by using User-Agent headers to distinguish browser from server events ([#1110](#1110)) - Updated dependencies \[[`0942c8a`](0942c8a), [`bce012e`](bce012e), [`7624030`](7624030), [`15a7f41`](15a7f41), [`13da542`](13da542), [`b3a654a`](b3a654a)]: - @spotlightjs/[email protected] - @spotlightjs/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1107.
This PR significantly improves SDK categorization by incorporating multiple signals beyond just the SDK name.
Why these changes?
Modern meta-frameworks (e.g., Next.js, Astro) can generate events from both client (browser) and server (Node.js) environments. Relying solely on the SDK name is insufficient to accurately distinguish these origins.
This PR enhances the
categorizeSDKlogic to use a more robust priority order:User-Agentfrom the incoming HTTP request, providing a strong signal for browser vs. server origin.event.tags.runtimefor "browser" indication.event.contexts.runtime.name,event.server_name, andevent.platformfor server-side indicators.This allows for more accurate classification of events, especially for meta-frameworks, ensuring that events from the browser part of a Next.js app are correctly labeled as "browser" and those from the server part as "server".