Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Nov 6, 2025

No description provided.

@BYK BYK enabled auto-merge (squash) November 6, 2025 22:11
@BYK BYK deployed to Preview November 6, 2025 22:11 — with GitHub Actions Active
@vercel
Copy link

vercel bot commented Nov 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
spotlightjs Ready Ready Preview Comment Nov 6, 2025 10:12pm

@BYK BYK merged commit 43318aa into main Nov 6, 2025
20 checks passed
@BYK BYK deleted the byk/ci/fix-notarization-confusion branch November 6, 2025 22:16
cursor bot pushed a commit that referenced this pull request Nov 7, 2025
Merged commits:
- b3a654a: Improve SDK categorization implementation (#1110)
- 43318aa: ci: Fix notarization env var swap (#1109)

Key changes from main:
- Enhanced SDK categorization using multiple signals (User-Agent, runtime tags,
  platform, server-specific signals) for better browser vs server detection
- Fixed notarization environment variables in CI
- Updated formatters to use improved categorization logic

Conflict resolutions:
- Kept our consolidated package structure (ui/, sidecar/, electron/)
- Maintained separate build configs (vite.config.ts for UI library,
  vite.ui.config.ts for static assets, tsc for sidecar)
- Preserved path aliases and electron app description
- Removed TypeScript types from bin/run.js since it's a JS file
- Fixed duplicate RAW_TYPES import in envelopesSlice.ts
- Added core dump files to .gitignore

All SDK categorization improvements have been merged into our
consolidated structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants