feat(sidecar): Auto capture stdio logs as Sentry log events #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `spotlight run` if the process is not using Sentry SDK with logs integration, we lose all its logging output that comes to stdout/stderr. This change automatically captures that output checks against any log items we receive from the process on the sidecar and sends them as Sentry log events only if we cannot get any logs from our integration.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
124
to
134
| logger.debug("Detected Sentry logging in the process, disabling stdio relay"); | ||
| relayStdioAsLogs = false; | ||
| // Return false to skip this log (prevent duplicate) | ||
| return false; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return true; | ||
| }; |
There was a problem hiding this comment.
Bug: fuzzySearcher starts empty, causing relayStdioAsLogs to remain true if SDK logs arrive first.
Severity: HIGH | Confidence: 0.90
🔍 Detailed Analysis
The fuzzySearcher is initialized empty. If Sentry SDK logs are received by the sidecar via the /stream endpoint before any stdout/stderr data has been processed and added to the searcher, the fuzzySearcher.search() operation will not find any matches. This prevents the relayStdioAsLogs flag from being correctly set to false, leading to continued duplication of logs where both stdout/stderr and SDK logs are sent.
💡 Suggested Fix
Ensure fuzzySearcher is populated with initial stdout/stderr data before processing SDK logs, or delay SDK log processing. Alternatively, initialize relayStdioAsLogs to false and only set it to true if no SDK logs are detected.
🤖 Prompt for AI Agent
Fix this bug. In packages/sidecar/src/cli/run.ts at lines 91-134: The `fuzzySearcher` is
initialized empty. If Sentry SDK logs are received by the sidecar via the `/stream`
endpoint before any stdout/stderr data has been processed and added to the searcher, the
`fuzzySearcher.search()` operation will not find any matches. This prevents the
`relayStdioAsLogs` flag from being correctly set to `false`, leading to continued
duplication of logs where both stdout/stderr and SDK logs are sent.
Did we get this right? 👍 / 👎 to inform future reviews.
betegon
reviewed
Oct 27, 2025
Member
betegon
left a comment
betegon
left a comment
There was a problem hiding this comment.
great one! one step closer to a great spotlight run
This pull request contains changes generated by Cursor background composer. <a href="https://cursor.com/background-agent?bcId=bc-b09007dd-6ca4-4563-9fe2-fef7f79fff99"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a> <a href="https://cursor.com/agents?id=bc-b09007dd-6ca4-4563-9fe2-fef7f79fff99"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --------- Co-authored-by: Cursor Agent <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This pull request contains changes generated by Cursor background composer. <a href="https://cursor.com/background-agent?bcId=bc-0b99054c-93b8-4ef8-8721-e278a246eab4"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a> <a href="https://cursor.com/agents?id=bc-0b99054c-93b8-4ef8-8721-e278a246eab4"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --------- Co-authored-by: Cursor Agent <[email protected]>
betegon
approved these changes
Oct 27, 2025
Member
betegon
left a comment
betegon
left a comment
There was a problem hiding this comment.
let's go. loved the new comments you added btw.
Member
Author
All Cursor 😅 |
betegon
added a commit
that referenced
this pull request
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
![https://cursor.com/open-in-cursor-dark.svg"><source](https://cursor.com/open-in-cursor-dark.svg"><source){kind=link}
![https://cursor.com/open-in-cursor-light.svg"><img](https://cursor.com/open-in-cursor-light.svg"><img){kind=link}
![https://cursor.com/open-in-cursor.svg"></picture></a> <a](https://cursor.com/open-in-cursor.svg"></picture></a> <a){kind=link}
![https://cursor.com/open-in-web-dark.svg"><source](https://cursor.com/open-in-web-dark.svg"><source){kind=link}
![https://cursor.com/open-in-web-light.svg"><img](https://cursor.com/open-in-web-light.svg"><img){kind=link}
![https://cursor.com/open-in-web.svg"></picture></a](https://cursor.com/open-in-web.svg"></picture></a){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
spotlight runif the process is not using Sentry SDKwith logs integration, we lose all its logging output that comes
to stdout/stderr. This change automatically captures that output
checks against any log items we receive from the process on the
sidecar and sends them as Sentry log events only if we cannot
get any logs from our integration.
Note: mostly vibe-coded