Generalize size limits based on envelope item type#2421
Merged
solnic merged 8 commits intoSep 30, 2024
Conversation
We don't set headers and payloads after initializing an item, so these accessors were not needed.
It's faster like that given that we rely on type value in multiple places
Same as with type, we rely on this value in multiple places so it makes no sense to keep calculating it multiple times
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2421 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 210 211 +1
Lines 13970 13987 +17
=======================================
+ Hits 13786 13803 +17
Misses 184 184
|
solnic
force-pushed
the
solnic/generalize-size-limits-based-on-envelope-item-type
branch
from
September 30, 2024 11:02
912f4e0 to
ca2660f
Compare
solnic
marked this pull request as ready for review
September 30, 2024 11:02
solnic
commented
Sep 30, 2024
sl0thentr0py
approved these changes
Sep 30, 2024
solnic
force-pushed
the
solnic/generalize-size-limits-based-on-envelope-item-type
branch
from
September 30, 2024 12:08
7621ef0 to
0aafa71
Compare
solnic
deleted the
solnic/generalize-size-limits-based-on-envelope-item-type
branch
September 30, 2024 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2413