Use Concurrent.available_processor_count instead of Concurrent.usable_processor_count#2358
Merged
Merged
Conversation
Contributor
Author
|
cc. @st0012 |
st0012
self-requested a review
August 5, 2024 22:26
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2358 +/- ##
==========================================
+ Coverage 98.68% 98.77% +0.09%
==========================================
Files 207 196 -11
Lines 13741 13241 -500
==========================================
- Hits 13560 13079 -481
+ Misses 181 162 -19
|
st0012
approved these changes
Aug 5, 2024
st0012
left a comment
st0012
left a comment
Contributor
There was a problem hiding this comment.
Sorry that I missed the renaming 🤦♂️
Can you also add a changelog entry? Otherwise it looks good, thank you!
…ble_processor_count`
heka1024
force-pushed
the
available-processor-count
branch
from
August 9, 2024 19:06
a2a1c7a to
c9a8ff0
Compare
Contributor
Author
|
@st0012 I just added a changelog. |
Contributor
|
The CI failure is caused by sidekiq running tests with Rails 7.2, which our current test setup hasn't supported yet. So it's not related to this PR's change and I'm merging it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Concurrent.usable_processor_countchanged toConcurrent.available_processor_countwhile code review so, we should use ``Concurrent.available_processor_count`.Concurrent.available_processor_countmaybe returnnil. In those cases, I think we should useprocessor_count.aws-sdk-railsadapted similar logic. https://github.com/aws/aws-sdk-rails/blob/38117a13edc13623e42be5c180bd7d25892faba5/lib/aws/rails/sqs_active_job/executor.rb#L12