Make sure isolated envelopes respect enabled_environments#2291
Merged
Conversation
sl0thentr0py
force-pushed
the
neel/enabled-env-metrics
branch
from
April 8, 2024 15:05
7bbbb4c to
9ab0fd4
Compare
Envelopes for metrics/sessions and so on were queued directly before and thus did not respect the config. This introduces a dedicated `capture_envelope` on the client to centralize these checks. Closes #2287
sl0thentr0py
force-pushed
the
neel/enabled-env-metrics
branch
from
April 9, 2024 13:01
9ab0fd4 to
c353dcc
Compare
sl0thentr0py
marked this pull request as ready for review
April 9, 2024 13:01
cleptric
approved these changes
Apr 9, 2024
Comment on lines
+207
to
+208
| # note that we don't record client reports for direct envelope types | ||
| # such as metrics, sessions etc |
Member
There was a problem hiding this comment.
We do have data categories for both sessions and metrics, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Envelopes for metrics/sessions and so on were queued directly before and thus did not respect the config. This introduces a dedicated
capture_envelopeon the client to centralize these checks.Closes #2287