Add before_emit callback for metrics#2258
Merged
sl0thentr0py merged 1 commit intoMar 12, 2024
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## neel/metrics/span-aggregator #2258 +/- ##
================================================================
+ Coverage 97.54% 97.57% +0.02%
================================================================
Files 112 112
Lines 4108 4116 +8
================================================================
+ Hits 4007 4016 +9
+ Misses 101 100 -1
|
sl0thentr0py
force-pushed
the
neel/metrics/before-emit
branch
from
March 8, 2024 14:08
bcd1c02 to
39b339a
Compare
Closed
sl0thentr0py
changed the title
sl0thentr0py
changed the title
st0012
reviewed
Mar 8, 2024
sl0thentr0py
force-pushed
the
neel/metrics/span-aggregator
branch
from
March 12, 2024 13:04
2a4ea74 to
116318b
Compare
sl0thentr0py
force-pushed
the
neel/metrics/before-emit
branch
from
March 12, 2024 13:15
39b339a to
da14eaf
Compare
antonpirker
approved these changes
Mar 12, 2024
antonpirker
left a comment
antonpirker
left a comment
Contributor
There was a problem hiding this comment.
Look good from my side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #2246