Metric summaries on span#2255
Merged
Merged
Conversation
Closed
sl0thentr0py
force-pushed
the
neel/metrics/span-aggregator
branch
from
March 6, 2024 15:46
9a6569c to
6dc3b72
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2255 +/- ##
==========================================
- Coverage 97.56% 97.54% -0.03%
==========================================
Files 111 112 +1
Lines 4060 4108 +48
==========================================
+ Hits 3961 4007 +46
- Misses 99 101 +2
|
sl0thentr0py
force-pushed
the
neel/metrics/span-aggregator
branch
6 times, most recently
from
March 8, 2024 13:17
b7a6537 to
bf28b5c
Compare
sl0thentr0py
force-pushed
the
neel/metrics/timing
branch
from
March 12, 2024 12:59
094e4aa to
e6bbb90
Compare
antonpirker
approved these changes
Mar 12, 2024
antonpirker
left a comment
antonpirker
left a comment
Contributor
There was a problem hiding this comment.
Looks like it does the same as Python. (Again, I am no Ruby dev so some things (in tests) look like black magic) But I guess this is ok.
* add a `LocalAggregator` instance on spans to duplicate metrics on the span as a gauge metric * proxy the main aggregator add calls to the local aggregator if a span is running * start a `metrics.timing` span in the `Sentry::Metrics.timing` API
sl0thentr0py
force-pushed
the
neel/metrics/span-aggregator
branch
from
March 12, 2024 13:04
2a4ea74 to
116318b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalAggregatorinstance on spans to duplicate metrics on the span as a gauge metricmetric.timingspan in theSentry::Metrics.timingAPIpart of #2246