Skip to content

Add sampled field to dynamic_sampling_context#2092

Merged
sl0thentr0py merged 1 commit into
masterfrom
neel/dsc-sampled
Aug 21, 2023
Merged

Add sampled field to dynamic_sampling_context#2092
sl0thentr0py merged 1 commit into
masterfrom
neel/dsc-sampled

Conversation

@sl0thentr0py

@sl0thentr0py sl0thentr0py commented Aug 17, 2023

Copy link
Copy Markdown
Member

@sl0thentr0py
sl0thentr0py requested a review from st0012 August 17, 2023 11:43
@codecov

codecov Bot commented Aug 17, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +9.43% 🎉

Comparison is base (8abb2d2) 73.82% compared to head (6ebd0d6) 83.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
+ Coverage   73.82%   83.25%   +9.43%     
==========================================
  Files          91      119      +28     
  Lines        4175     5674    +1499     
==========================================
+ Hits         3082     4724    +1642     
+ Misses       1093      950     -143     
Files Changed Coverage Δ
sentry-ruby/lib/sentry/transaction.rb 76.00% <ø> (ø)

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antonpirker antonpirker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@szokeasaurusrex szokeasaurusrex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright

@st0012 st0012 added this to the 5.11.0 milestone Aug 20, 2023
@sl0thentr0py
sl0thentr0py merged commit 86dfaea into master Aug 21, 2023
@sl0thentr0py
sl0thentr0py deleted the neel/dsc-sampled branch August 21, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Sampling Decision to Trace Envelope Header

4 participants