Baggage creation for head SDK#1898
Merged
sl0thentr0py merged 5 commits intoSep 27, 2022
Merged
Conversation
sl0thentr0py
force-pushed
the
neel/baggage-dsc-head
branch
from
September 15, 2022 13:59
fa60be0 to
b246e8a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## neel/baggage-dsc-continuation #1898 +/- ##
=================================================================
- Coverage 98.42% 98.41% -0.01%
=================================================================
Files 150 150
Lines 9096 9177 +81
=================================================================
+ Hits 8953 9032 +79
- Misses 143 145 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sl0thentr0py
marked this pull request as ready for review
September 19, 2022 10:58
st0012
reviewed
Sep 19, 2022
sl0thentr0py
force-pushed
the
neel/baggage-dsc-continuation
branch
from
September 19, 2022 12:08
7490335 to
8b8af16
Compare
sl0thentr0py
force-pushed
the
neel/baggage-dsc-head
branch
2 times, most recently
from
September 19, 2022 12:36
a605ce7 to
c9764dd
Compare
sl0thentr0py
force-pushed
the
neel/baggage-dsc-head
branch
from
September 19, 2022 12:59
c9764dd to
ef80c2f
Compare
st0012
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates new
Baggageentries when the ruby SDK is thehead SDK, i.e the first SDK that originates a distributed trace.The new
Baggageentry is created whenget_baggageis first called, eithercloses #1836