feat(performance): Sync activerecord and net-http span names#1681
Conversation
…o work with discover slow ops dashboards
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
See the current accepted span operation prefixes: https://github.com/getsentry/sentry/blob/809b7fe54c6f06cc1e4c503cf83ded896472a011/src/sentry/projectoptions/defaults.py#L74
st0012
left a comment
st0012
left a comment
There was a problem hiding this comment.
Thanks for the fix! Can you also add a changelog entry for it?
|
@sl0thentr0py sorry I missed one thing: perhaps we can also add |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1681 +/- ##
==========================================
+ Coverage 98.37% 98.39% +0.01%
==========================================
Files 136 136
Lines 7830 7833 +3
==========================================
+ Hits 7703 7707 +4
+ Misses 127 126 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Yea I added those then removed it because I wasn't able to make it clean. The db one works with prefixes, if we go with a prefix for views it'll look like Nicer would be |
|
nvm I just added the prefix, it's not the nicest looking with repetition but it's fine for now.. |
|
Since it's to support a feature, I think the duplication is fine. |
st0012
left a comment
st0012
left a comment
There was a problem hiding this comment.
Thanks for the feature! I'll put this to 5.1.0 release, which will be released soon after 5.0
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
* master: feat(performance): Sync activerecord and net-http span names (getsentry#1681) Register Sentry's ErrorSubscriber for Rails 7.0+ apps (getsentry#1705) Support serializing ActiveRecord job arguments in global id form (getsentry#1688) release: 5.0.2 Fix report_after_job_retries's decision logic (getsentry#1704) Followup of getsentry#1701 (getsentry#1703) Capture transaction tags (getsentry#1701)
4 participants
The span prefixes are needed as documented here for the discover slow ops dashboards to be populated successfully.
Note that this won't break any existing user queries since we currently don't allow filtering/searching by span ops.
Fixes #1674