Add query string & body to Net::HTTP breadcrumb#1642
Merged
st0012 merged 3 commits intoDec 26, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
==========================================
- Coverage 98.50% 98.47% -0.03%
==========================================
Files 135 135
Lines 7606 7663 +57
==========================================
+ Hits 7492 7546 +54
- Misses 114 117 +3
Continue to review full report at Codecov.
|
ojab
marked this pull request as ready for review
December 13, 2021 16:06
ojab
force-pushed
the
add_query_string_and_body_to_net_http_breadcrumbs
branch
from
December 13, 2021 16:06
548e8bd to
0f29767
Compare
Contributor
|
@ojab hey sorry for the trouble, but do you think you can rebase the PR? thx! |
ojab
force-pushed
the
add_query_string_and_body_to_net_http_breadcrumbs
branch
from
December 24, 2021 15:30
0f29767 to
c6a000f
Compare
ojab
force-pushed
the
add_query_string_and_body_to_net_http_breadcrumbs
branch
from
December 24, 2021 15:33
c6a000f to
9eb3590
Compare
ojab
force-pushed
the
add_query_string_and_body_to_net_http_breadcrumbs
branch
from
December 24, 2021 15:34
9eb3590 to
f8ed9f6
Compare
Contributor
Author
|
Sure thing, rebased, CI is green. |
st0012
reviewed
Dec 26, 2021
st0012
left a comment
st0012
left a comment
Contributor
There was a problem hiding this comment.
Some small comments but nothing blocking. Thanks for the awesome feature 👍
|
|
||
| { method: req.method, url: url } | ||
| rescue | ||
| { method: req.method, url: url.to_s } |
Contributor
There was a problem hiding this comment.
this should be uri.to_s. I'll change it after merging.
| return if from_sentry_sdk? | ||
|
|
||
| request_info = extract_request_info(req) | ||
| request_info[:body] = req.body if Sentry.configuration.send_default_pii |
Contributor
There was a problem hiding this comment.
this extraction should happen inside extract_request_info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
They are useful, let's add them.
This is on top of #1637 because they're touching the same code and probably #1637 would be merged faster.