Skip to content

Correct license of new SDK gems#1554

Merged
st0012 merged 3 commits into
masterfrom
correct-license
Sep 1, 2021
Merged

Correct license of new SDK gems#1554
st0012 merged 3 commits into
masterfrom
correct-license

Conversation

@st0012

@st0012 st0012 commented Aug 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Keep the old sentry-raven with Apache-2, but new gems should be MIT.

@st0012 st0012 added this to the 4.7.0 milestone Aug 28, 2021
@st0012 st0012 self-assigned this Aug 28, 2021
@st0012
st0012 requested review from HazAT and rhcarvalho August 28, 2021 07:56
@timhaines

timhaines commented Aug 28, 2021

Copy link
Copy Markdown

Thanks @st0012! 💯

bruno-garcia
bruno-garcia approved these changes Aug 30, 2021
View reviewed changes

@bruno-garcia bruno-garcia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given that the repo is Apache 2: https://github.com/getsentry/sentry-ruby/blob/master/LICENSE

mitsuhiko
mitsuhiko suggested changes Aug 30, 2021
View reviewed changes

@mitsuhiko mitsuhiko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the desire was for this to be MIT licensed.

@st0012
st0012 requested a review from mitsuhiko August 30, 2021 12:47
@st0012 st0012 changed the title Correct license files of new SDK gems Correct license of new SDK gems Aug 30, 2021
@codecov-commenter

codecov-commenter commented Aug 30, 2021 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.29%. Comparing base (b285753) to head (553cbc7).
⚠️ Report is 739 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1554      +/-   ##
==========================================
+ Coverage   97.92%   98.29%   +0.37%     
==========================================
  Files         222      127      -95     
  Lines       10867     7030    -3837     
==========================================
- Hits        10641     6910    -3731     
+ Misses        226      120     -106

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rhcarvalho
rhcarvalho reviewed Aug 30, 2021
View reviewed changes

@rhcarvalho rhcarvalho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could make LICENSE a symlink to sentry-ruby/LICENSE.txt, similar to how README is a symlink.
By removing the file I'm afraid it will remove the license information that GitHub publishes about the repo:

image

@st0012

st0012 commented Aug 30, 2021

Copy link
Copy Markdown
Contributor Author

@rhcarvalho 👍 updated

@bruno-garcia

bruno-garcia commented Aug 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Shouldn't those be licensed to sentry? It's with your github handle

The MIT License (MIT)

Copyright (c) 2020 st0012

@st0012

st0012 commented Aug 31, 2021

Copy link
Copy Markdown
Contributor Author

@bruno-garcia good catch 👍 all updated

@st0012

st0012 commented Aug 31, 2021

Copy link
Copy Markdown
Contributor Author

@mitsuhiko may I merge this?

@st0012
st0012 merged commit 4e7eb21 into master Sep 1, 2021
@st0012
st0012 deleted the correct-license branch September 1, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes
@HazAT HazAT Awaiting requested review from HazAT
@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko
+1 more reviewer
@rhcarvalho rhcarvalho rhcarvalho approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@st0012 st0012

Labels

sentry-delayed_job sentry-rails sentry-resque sentry-ruby sentry-sidekiq

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

6 participants

@st0012 @timhaines @codecov-commenter @bruno-garcia @mitsuhiko @rhcarvalho