test(e2e): Update iOS envelope header test by antonis · Pull Request #5623 · getsentry/sentry-react-native

antonis · 2026-02-06T10:14:06Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

The change matches the spec at https://develop.sentry.dev/sdk/telemetry/traces/dynamic-sampling-context/#dsc-specification

💡 Motivation and Context

Fix consistently failing Test ios production REV2

💚 How did you test it?

CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

Updates envelope header trace expectations to match Cocoa SDK v9 format: - Changed sampled field from "1" to "true" (per sentry-cocoa#3067) - Added sample_rand field validation for Dynamic Sampling Context This change is required after upgrading from Cocoa 8.58.0 to 9.3.0 on the v8 branch. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

github-actions · 2026-02-06T10:14:25Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

This PR will not appear in the changelog.

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-02-06T10:29:29Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	465.44 ms	518.98 ms	53.54 ms
Size	43.75 MiB	48.41 MiB	4.66 MiB

Baseline results on branch: v8

Startup times

Revision	Plain	With Sentry	Diff
`d382e88`+dirty	449.86 ms	431.04 ms	-18.82 ms
`12fba4a`+dirty	483.60 ms	514.49 ms	30.89 ms
`2af2313`+dirty	412.86 ms	428.31 ms	15.45 ms
`fa0d109`+dirty	429.60 ms	452.50 ms	22.90 ms
`bc8a1ed`+dirty	442.18 ms	476.27 ms	34.08 ms
`7f6455d`+dirty	409.48 ms	433.66 ms	24.18 ms
`b4fa5b4`+dirty	449.55 ms	481.50 ms	31.95 ms
`d6aa223`+dirty	543.40 ms	564.24 ms	20.84 ms
`4d0472d`+dirty	429.60 ms	457.96 ms	28.36 ms
`206e87e`+dirty	464.80 ms	504.68 ms	39.88 ms

App size

Revision	Plain	With Sentry	Diff
`d382e88`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`12fba4a`+dirty	43.75 MiB	48.40 MiB	4.64 MiB
`2af2313`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`fa0d109`+dirty	43.75 MiB	48.40 MiB	4.64 MiB
`bc8a1ed`+dirty	43.75 MiB	48.08 MiB	4.33 MiB
`7f6455d`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`b4fa5b4`+dirty	43.75 MiB	48.08 MiB	4.33 MiB
`d6aa223`+dirty	43.75 MiB	48.55 MiB	4.80 MiB
`4d0472d`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`206e87e`+dirty	43.75 MiB	48.40 MiB	4.64 MiB

Previous results on branch: antonis/v8-sample-ios

Startup times

Revision	Plain	With Sentry	Diff
`39506e8`+dirty	453.70 ms	471.60 ms	17.90 ms
`3acc593`+dirty	413.40 ms	442.86 ms	29.46 ms
`2e7672a`+dirty	484.86 ms	515.86 ms	31.00 ms
`29e64bc`+dirty	490.94 ms	556.38 ms	65.44 ms

App size

Revision	Plain	With Sentry	Diff
`39506e8`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`3acc593`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`2e7672a`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`29e64bc`+dirty	43.75 MiB	48.41 MiB	4.66 MiB

github-actions · 2026-02-06T10:37:00Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1207.70 ms	1215.75 ms	8.05 ms
Size	3.38 MiB	4.76 MiB	1.38 MiB

Baseline results on branch: v8

Startup times

Revision	Plain	With Sentry	Diff
`d382e88`+dirty	1214.17 ms	1212.22 ms	-1.95 ms
`d6aa223`+dirty	1192.33 ms	1208.17 ms	15.84 ms
`206e87e`+dirty	1184.11 ms	1183.19 ms	-0.92 ms
`bc8a1ed`+dirty	1194.70 ms	1201.18 ms	6.48 ms
`12fba4a`+dirty	1214.20 ms	1223.30 ms	9.09 ms
`4d0472d`+dirty	1203.83 ms	1212.10 ms	8.27 ms
`7f6455d`+dirty	1201.47 ms	1206.83 ms	5.36 ms
`fa0d109`+dirty	1216.02 ms	1220.67 ms	4.65 ms
`b4fa5b4`+dirty	1203.83 ms	1207.13 ms	3.30 ms
`2af2313`+dirty	1212.38 ms	1213.21 ms	0.83 ms

App size

Revision	Plain	With Sentry	Diff
`d382e88`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`d6aa223`+dirty	3.38 MiB	4.67 MiB	1.29 MiB
`206e87e`+dirty	3.38 MiB	4.67 MiB	1.29 MiB
`bc8a1ed`+dirty	3.44 MiB	4.66 MiB	1.22 MiB
`12fba4a`+dirty	3.38 MiB	4.67 MiB	1.29 MiB
`4d0472d`+dirty	3.38 MiB	4.76 MiB	1.37 MiB
`7f6455d`+dirty	3.38 MiB	4.76 MiB	1.37 MiB
`fa0d109`+dirty	3.38 MiB	4.67 MiB	1.29 MiB
`b4fa5b4`+dirty	3.44 MiB	4.66 MiB	1.22 MiB
`2af2313`+dirty	3.38 MiB	4.76 MiB	1.38 MiB

Previous results on branch: antonis/v8-sample-ios

Startup times

Revision	Plain	With Sentry	Diff
`29e64bc`+dirty	1220.28 ms	1219.73 ms	-0.55 ms
`3acc593`+dirty	1210.33 ms	1208.30 ms	-2.04 ms
`2e7672a`+dirty	1225.55 ms	1221.66 ms	-3.89 ms
`39506e8`+dirty	1209.81 ms	1210.30 ms	0.49 ms

App size

Revision	Plain	With Sentry	Diff
`29e64bc`+dirty	3.38 MiB	4.76 MiB	1.37 MiB
`3acc593`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`2e7672a`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`39506e8`+dirty	3.38 MiB	4.76 MiB	1.38 MiB

github-actions · 2026-02-06T10:54:07Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	409.23 ms	445.64 ms	36.41 ms
Size	43.94 MiB	49.27 MiB	5.33 MiB

Baseline results on branch: v8

Startup times

Revision	Plain	With Sentry	Diff
`d382e88`+dirty	362.92 ms	407.68 ms	44.76 ms
`12fba4a`+dirty	456.57 ms	462.90 ms	6.32 ms
`2af2313`+dirty	409.42 ms	436.65 ms	27.23 ms
`fa0d109`+dirty	413.71 ms	434.22 ms	20.51 ms
`bc8a1ed`+dirty	396.10 ms	426.80 ms	30.69 ms
`7f6455d`+dirty	378.08 ms	432.36 ms	54.28 ms
`b4fa5b4`+dirty	382.09 ms	398.28 ms	16.19 ms
`d6aa223`+dirty	436.98 ms	466.42 ms	29.44 ms
`4d0472d`+dirty	375.89 ms	448.61 ms	72.72 ms
`206e87e`+dirty	416.94 ms	440.98 ms	24.04 ms

App size

Revision	Plain	With Sentry	Diff
`d382e88`+dirty	43.94 MiB	49.27 MiB	5.33 MiB
`12fba4a`+dirty	43.94 MiB	49.22 MiB	5.29 MiB
`2af2313`+dirty	43.94 MiB	49.27 MiB	5.33 MiB
`fa0d109`+dirty	43.94 MiB	49.22 MiB	5.29 MiB
`bc8a1ed`+dirty	43.94 MiB	48.91 MiB	4.97 MiB
`7f6455d`+dirty	43.94 MiB	49.27 MiB	5.33 MiB
`b4fa5b4`+dirty	43.94 MiB	48.91 MiB	4.97 MiB
`d6aa223`+dirty	43.94 MiB	49.38 MiB	5.44 MiB
`4d0472d`+dirty	43.94 MiB	49.27 MiB	5.33 MiB
`206e87e`+dirty	43.94 MiB	49.22 MiB	5.29 MiB

Previous results on branch: antonis/v8-sample-ios

Startup times

Revision	Plain	With Sentry	Diff
`39506e8`+dirty	405.00 ms	453.74 ms	48.74 ms
`3acc593`+dirty	371.08 ms	426.89 ms	55.81 ms
`2e7672a`+dirty	460.54 ms	501.59 ms	41.05 ms
`29e64bc`+dirty	396.37 ms	430.22 ms	33.85 ms

App size

Revision	Plain	With Sentry	Diff
`39506e8`+dirty	43.94 MiB	49.27 MiB	5.33 MiB
`3acc593`+dirty	43.94 MiB	49.27 MiB	5.33 MiB
`2e7672a`+dirty	43.94 MiB	49.27 MiB	5.33 MiB
`29e64bc`+dirty	43.94 MiB	49.27 MiB	5.33 MiB

github-actions · 2026-02-06T11:14:17Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1214.33 ms	1238.94 ms	24.60 ms
Size	3.38 MiB	4.76 MiB	1.38 MiB

Baseline results on branch: v8

Startup times

Revision	Plain	With Sentry	Diff
`d382e88`+dirty	1214.31 ms	1215.00 ms	0.69 ms
`d6aa223`+dirty	1216.76 ms	1213.40 ms	-3.37 ms
`206e87e`+dirty	1197.12 ms	1204.25 ms	7.13 ms
`bc8a1ed`+dirty	1198.66 ms	1200.60 ms	1.94 ms
`12fba4a`+dirty	1209.43 ms	1217.08 ms	7.65 ms
`4d0472d`+dirty	1210.70 ms	1222.23 ms	11.53 ms
`7f6455d`+dirty	1198.98 ms	1199.37 ms	0.39 ms
`fa0d109`+dirty	1206.81 ms	1205.38 ms	-1.43 ms
`b4fa5b4`+dirty	1213.59 ms	1211.26 ms	-2.33 ms
`2af2313`+dirty	1203.02 ms	1213.87 ms	10.85 ms

App size

Revision	Plain	With Sentry	Diff
`d382e88`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`d6aa223`+dirty	3.38 MiB	4.67 MiB	1.29 MiB
`206e87e`+dirty	3.38 MiB	4.67 MiB	1.29 MiB
`bc8a1ed`+dirty	3.44 MiB	4.66 MiB	1.22 MiB
`12fba4a`+dirty	3.38 MiB	4.67 MiB	1.29 MiB
`4d0472d`+dirty	3.38 MiB	4.76 MiB	1.37 MiB
`7f6455d`+dirty	3.38 MiB	4.76 MiB	1.37 MiB
`fa0d109`+dirty	3.38 MiB	4.67 MiB	1.29 MiB
`b4fa5b4`+dirty	3.44 MiB	4.66 MiB	1.22 MiB
`2af2313`+dirty	3.38 MiB	4.76 MiB	1.38 MiB

Previous results on branch: antonis/v8-sample-ios

Startup times

Revision	Plain	With Sentry	Diff
`29e64bc`+dirty	1221.51 ms	1216.33 ms	-5.18 ms
`3acc593`+dirty	1204.44 ms	1201.29 ms	-3.15 ms
`2e7672a`+dirty	1203.84 ms	1209.43 ms	5.60 ms
`39506e8`+dirty	1207.72 ms	1220.46 ms	12.74 ms

App size

Revision	Plain	With Sentry	Diff
`29e64bc`+dirty	3.38 MiB	4.76 MiB	1.37 MiB
`3acc593`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`2e7672a`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`39506e8`+dirty	3.38 MiB	4.76 MiB	1.38 MiB

antonis

Note that the commit description is incorrectly the cocoa bump as the root of the issue. This will be fixed in the squash commit

lucas-zimerman

LGTM!

antonis added the ready-to-merge Triggers the full CI test suite label Feb 6, 2026

antonis changed the title ~~test(e2e): Update iOS envelope header test for Cocoa SDK v9~~ test(e2e): Update iOS envelope header test Feb 6, 2026

antonis mentioned this pull request Feb 6, 2026

chore(deps): v8: update Cocoa SDK to v9.4.0 #5619

Merged

10 tasks

antonis commented Feb 6, 2026

View reviewed changes

antonis added 3 commits February 6, 2026 13:16

Merge branch 'v8' into antonis/v8-sample-ios

07bc946

Merge branch 'v8' into antonis/v8-sample-ios

54f510d

Merge branch 'v8' into antonis/v8-sample-ios

9d62b3b

antonis marked this pull request as ready for review February 10, 2026 14:54

antonis requested review from alwx and lucas-zimerman as code owners February 10, 2026 14:54

Merge branch 'v8' into antonis/v8-sample-ios

fad1b7f

lucas-zimerman approved these changes Feb 11, 2026

View reviewed changes

antonis merged commit 77018cc into v8 Feb 11, 2026
145 of 149 checks passed

antonis deleted the antonis/v8-sample-ios branch February 11, 2026 15:07

claude bot added the claude-code-assisted label Feb 12, 2026

Uh oh!

Comments

Conversation

antonis commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: v8

Startup times

App size

Previous results on branch: antonis/v8-sample-ios

Startup times

App size

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: v8

Startup times

App size

Previous results on branch: antonis/v8-sample-ios

Startup times

App size

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: v8

Startup times

App size

Previous results on branch: antonis/v8-sample-ios

Startup times

App size

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: v8

Startup times

App size

Previous results on branch: antonis/v8-sample-ios

Startup times

App size

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

antonis commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading