feat(core): Exclude Dev Server and Sentry Dsn request from Breadcrumbs#4240
Merged
feat(core): Exclude Dev Server and Sentry Dsn request from Breadcrumbs#4240
Conversation
# Conflicts: # RNSentry.podspec
# Conflicts: # android/src/main/java/io/sentry/react/RNSentryModuleImpl.java
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # packages/core/android/src/main/java/io/sentry/react/RNSentryBreadcrumb.java
# Conflicts: # CHANGELOG.md # packages/core/RNSentry.podspec
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
antonis
changed the title
Co-authored-by: LucasZF <[email protected]>
Co-authored-by: LucasZF <[email protected]>
Co-authored-by: LucasZF <[email protected]>
packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java
Outdated
Show resolved
Hide resolved
packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.mm
Outdated
Show resolved
Hide resolved
Co-authored-by: LucasZF <[email protected]>
lucas-zimerman
approved these changes
Nov 15, 2024
Collaborator
lucas-zimerman
left a comment
lucas-zimerman
left a comment
There was a problem hiding this comment.
That's all from my side, once the comments are resolved, we could merge this PR!
Thank you for your work!
Contributor
Author
|
Thank you for all the help on this PR @lucas-zimerman 🙇 |
Contributor
|
One non blocking note, the native breadcrumbs filter will not work for users who manually initialize the native SDKs. This is acceptable now, as there are other features which are not enabled when using manual init. But it will need update when implementing #3608 |
This was referenced Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Filters out DevServer and DSN related breadcrumbs using the
beforeBreadcrumboption on iOS, Android and JS:Note: The current implementation excludes breadcrumbs with the dev server including the port. For example
http://localhost:8081breadcrumbs are excluded buthttp://localhost:8969/streamare not. A possible enhancement would be to get the host name from the dev server url and exclude all requests. This might have the side effect of missing other requests from a local development environment.💡 Motivation and Context
Fixes #3105
💚 How did you test it?
CI, Manual testing
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps