feat(replay): Add Mobile Replay Alpha by krystofwoldrich · Pull Request #3714 · getsentry/sentry-react-native

krystofwoldrich · 2024-03-25T09:37:59Z

📢 Type of change

New feature

Todo before merge

~~Release sentry-android stable version with experimental implementation of Replay~~ (or merge with the alpha release to a clean feature branch which will be later merged to main)
Add tests for MobileReplay options are passed to native init
Add tests for SDK options enabling the Replay intergation
Add tests for native options mapping (iOS and Android)
Enable buffered mode in E2E tests (if possible)
Review

Done

Done for `alpha.0` release

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

#skip-changelog

github-actions · 2024-03-25T10:07:30Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1222.00 ms	1223.49 ms	1.49 ms
Size	2.36 MiB	2.92 MiB	571.08 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`0db0c72`+dirty	1275.02 ms	1285.84 ms	10.82 ms
`9433f35`+dirty	1246.94 ms	1271.45 ms	24.52 ms
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`27ef4ee`+dirty	1293.52 ms	1296.08 ms	2.56 ms
`d7401ac`+dirty	1252.38 ms	1275.04 ms	22.66 ms
`22e31b6`+dirty	1253.62 ms	1265.96 ms	12.34 ms

App size

Revision	Plain	With Sentry	Diff
`0db0c72`+dirty	2.36 MiB	2.84 MiB	487.01 KiB
`9433f35`+dirty	2.36 MiB	2.85 MiB	499.80 KiB
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`27ef4ee`+dirty	2.36 MiB	2.85 MiB	500.03 KiB
`d7401ac`+dirty	2.36 MiB	2.83 MiB	481.14 KiB
`22e31b6`+dirty	2.36 MiB	2.87 MiB	520.67 KiB

github-actions · 2024-03-25T10:23:17Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1218.39 ms	1219.85 ms	1.47 ms
Size	2.92 MiB	3.48 MiB	577.47 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`0db0c72`+dirty	1258.88 ms	1262.52 ms	3.64 ms
`9433f35`+dirty	1232.24 ms	1232.74 ms	0.50 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`e2b64fe`+dirty	1285.78 ms	1297.56 ms	11.78 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`27ef4ee`+dirty	1236.41 ms	1244.90 ms	8.49 ms
`d7401ac`+dirty	1288.10 ms	1289.54 ms	1.44 ms
`22e31b6`+dirty	1276.55 ms	1278.12 ms	1.57 ms

App size

Revision	Plain	With Sentry	Diff
`0db0c72`+dirty	2.92 MiB	3.40 MiB	492.71 KiB
`9433f35`+dirty	2.92 MiB	3.41 MiB	503.55 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`e2b64fe`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`27ef4ee`+dirty	2.92 MiB	3.41 MiB	503.72 KiB
`d7401ac`+dirty	2.92 MiB	3.40 MiB	488.06 KiB
`22e31b6`+dirty	2.92 MiB	3.43 MiB	524.74 KiB

github-actions · 2024-04-23T09:56:22Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	426.92 ms	452.41 ms	25.49 ms
Size	17.73 MiB	20.02 MiB	2.29 MiB

github-actions · 2024-04-23T10:08:01Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	312.93 ms	354.21 ms	41.28 ms
Size	7.15 MiB	8.30 MiB	1.15 MiB

src/js/integrations/mobilereplay.ts

lucas-zimerman · 2024-05-15T02:58:29Z

Should we bump feat/replay with main? There seems to have changes on kw-add-replay-v0 that are from the main branch but are missing on feat/replay, that could help cleaning the PR file changes by only pointing to the changes that were actually done on the PR

vaind · 2024-05-15T14:33:37Z

Is it possible to review this and get merged to feat/replay soonish? I'd rather not create a third PR in chain to land #3818

TODOs from this PR could move to feat/replay PR (which should only have reviewed code AFAIU) or a tracking issue.

krystofwoldrich · 2024-05-15T16:24:13Z

@lucas-zimerman @vaind @romtsn @brustolin Can, you take a look at this alpha PR? I would like to merge it as is to feat/replay where only review commits will go and then that will be eventually be merged without squash to main.

@billyvg @mydea Feel free to comment on the JS part, so RN doesn't unnecessarily deviate from browser replay.

vaind

LGTM but leaving approval to someone who knows the SDK.

CHANGELOG.md

src/js/integrations/mobilereplay.ts

src/js/utils/clientutils.ts

brustolin · 2024-05-17T13:56:56Z

RNSentry.podspec


  s.dependency 'React-Core'
-  s.dependency 'Sentry/HybridSDK', '8.25.2'
+  s.dependency 'Sentry/HybridSDK', '8.25.0-alpha.0'


We can target 8.26.0 now

Thanks, I'll do the bump.

lucas-zimerman

There are some comments that I made but nothing blocking so I am approving it for merge 🚀

Co-authored-by: LucasZF <[email protected]>

* feat(replay): Add Mobile Replay Alpha (#3714) * feat(sample): add running indicator (animation overlay) (#3903) * feat(replay): Add breadcrumbs mapping from RN to RRWeb format (#3846) * feat(replay): Add network breadcrumbs (#3912) * fix(replay): Add tests for touch events (#3924) * feat(replay): Filter Sentry event breadcrumbs (#3925) * fix(changelog): Add latest native SDKs details * release: 5.25.0-alpha.2 * misc(samples): Add console anything examples for replay testing (#3928) * feat: Add Sentry Babel Transformer (#3916) * fix(replay): Add app lifecycle breadcrumbs conversion tests (#3932) * chore(deps): bump sentry-android to 7.12.0-alpha.3 * chore(deps): bump sentry-android to 7.12.0-alpha.4 * fix(replay): Mask SVGs from `react-native-svg` when `maskAllVectors=true` (#3930) * fix(replay): Add missing properties to android nav breadcrumbs (#3942) * release: 5.26.0-alpha.3 * misc(replay): Add Mobile Replay Public Beta changelog (#3943) --------- Co-authored-by: Ivan Dlugos <[email protected]> Co-authored-by: Ivan Dlugos <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: Roman Zavarnitsyn <[email protected]> Co-authored-by: Bruno Garcia <[email protected]>

wip: Add Mobile Replay

cbaa720

Add mobile replay js interface

8a2580b

krystofwoldrich changed the title ~~wip: Add Mobile Replay~~ Add Mobile Replay Mar 25, 2024

Krystof Woldrich added 9 commits March 25, 2024 17:30

Simplify integration interface, always use native replayId

29c3ad9

remove unwanted style changes

de6669b

add pod fix for sentry-cocoa replay version

4a66cdd

fix java impl

2afdcc1

Add RN Components playground

10379f9

fix missing hard crash

f8eb045

Merge remote-tracking branch 'origin/main' into kw-add-replay-v0

f49f2fb

revert clags changes

1c9001b

Bump native SDKs to alphas with replay and add changelog

3abfca8

krystofwoldrich mentioned this pull request Apr 23, 2024

feat(replay): add captureReplay without Event param for Hybrid SDKs getsentry/sentry-cocoa#3878

Merged

Add replay tag in JS

82fbf4c

krystofwoldrich mentioned this pull request Apr 23, 2024

feat(replay): add Hybrid SDKs Replay interface getsentry/sentry-cocoa#3879

Merged

Krystof Woldrich added 3 commits April 23, 2024 16:12

add more robust is exception event check

a0727c9

Add on error sample rate to the sample app

8a291ed

Use cocoa impl of captureReplay

7f1c85f

This was referenced Apr 24, 2024

[SR] Add sendReplay method for Hybrid SDKs getsentry/sentry-java#3383

Merged

feat(replay): Expose ignore and redact classes to hybrid SDKs getsentry/sentry-cocoa#3891

Merged

Krystof Woldrich added 6 commits April 24, 2024 15:22

Add Android native replay options, capture replay and EMPTY_ID check

48be9e9

add redacting RCT text and images for iOS replay

f9acb41

revert replayID tag and context functions

e7eb005

fix lint

f792d2a

move replay options under experiments

2f8b8c8

enable replay in expo sample

615faaf

krystofwoldrich requested review from brustolin and romtsn April 30, 2024 09:22

krystofwoldrich marked this pull request as draft April 30, 2024 09:25

Krystof Woldrich added 3 commits May 6, 2024 10:47

Merge remote-tracking branch 'origin/main' into kw-add-replay-v0

5fd158e

fix session sample rate on Android

592f513

Merge remote-tracking branch 'origin/main' into kw-add-replay-v0

e293d5f

krystofwoldrich changed the title ~~feat(replay): Add Mobile Replay Alpha.0~~ feat(replay): Add Mobile Replay Alpha May 9, 2024

getsentry-bot and others added 2 commits May 9, 2024 15:57

release: 5.23.0-alpha.1

5519309

Merge branch 'release/5.23.0-alpha.1' into kw-add-replay-v0

0bd517d

getsentry deleted a comment from github-actions bot May 9, 2024

vaind reviewed May 13, 2024

View reviewed changes

src/js/integrations/mobilereplay.ts Outdated Show resolved Hide resolved

getsentry deleted a comment from github-actions bot May 15, 2024

Krystof Woldrich added 2 commits May 15, 2024 18:11

Merge branch 'feat/replay' into kw-add-replay-v0

48d8b35

rename startReplay to captureReplay

3177b5c

krystofwoldrich requested a review from vaind May 15, 2024 16:20

krystofwoldrich marked this pull request as ready for review May 15, 2024 16:26

vaind reviewed May 15, 2024

View reviewed changes

lucas-zimerman reviewed May 17, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

lucas-zimerman reviewed May 17, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

lucas-zimerman reviewed May 17, 2024

View reviewed changes

src/js/integrations/mobilereplay.ts Show resolved Hide resolved

lucas-zimerman reviewed May 17, 2024

View reviewed changes

src/js/utils/clientutils.ts Outdated Show resolved Hide resolved

brustolin reviewed May 17, 2024

View reviewed changes

lucas-zimerman approved these changes May 17, 2024

View reviewed changes

Update src/js/utils/clientutils.ts

50cbcda

Co-authored-by: LucasZF <[email protected]>

krystofwoldrich merged commit 60d07df into feat/replay May 21, 2024

krystofwoldrich deleted the kw-add-replay-v0 branch May 21, 2024 11:04

Uh oh!

Comments

Conversation

krystofwoldrich commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

Todo before merge

Done

Done for alpha.0 release

📝 Checklist

Uh oh!

github-actions bot commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Uh oh!

github-actions bot commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Uh oh!

Uh oh!

lucas-zimerman commented May 15, 2024

Uh oh!

vaind commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krystofwoldrich commented May 15, 2024

Uh oh!

vaind left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brustolin May 17, 2024

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich May 21, 2024

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

krystofwoldrich commented Mar 25, 2024 •

edited

Loading

Done for `alpha.0` release

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 23, 2024 •

edited

Loading

vaind commented May 15, 2024 •

edited

Loading