feat(profiling): Add Native iOS profiles to Hermes JS profiles #3349
Merged
Conversation
added 17 commits
October 11, 2023 13:18
…symbolicated-profiles
…symbolicated-profiles
…symbolicated-profiles
krystofwoldrich
changed the title
Contributor
|
This was referenced Oct 18, 2023
krystofwoldrich
changed the base branch from
main
to
kw-symbolicated-profiles
October 19, 2023 13:50
Closed
armcknight
reviewed
Nov 7, 2023
armcknight
left a comment
armcknight
left a comment
Member
There was a problem hiding this comment.
Couple quick things from me!
12 tasks
Co-authored-by: Andrew McKnight <[email protected]> Co-authored-by: LucasZF <[email protected]>
Contributor
Author
|
@armcknight @lucas-zimerman Thank you for the feedback. I've adjusted to code, can you take one more look? |
armcknight
approved these changes
Nov 15, 2023
Member
There was a problem hiding this comment.
Native code changes in this PR look good, nice work.
I noticed some preexisting code not covered in the diff, so I couldn't comment directly on it, but is this macro left undefined in the main branch, and you just define it to 1 if you're debugging locally?
sentry-react-native/ios/RNSentry.mm
Line 625 in cbb32a7
Contributor
Author
|
@armcknight Yes, exactly. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR adds native iOS profiles to currently existing RN Hermes profiles.
Hermes and Native profiles are merged on a device and sent as one profiling event in the envelope with associated Transaction.
💡 Motivation and Context
platformfield to profile frames relay#2629💚 How did you test it?
sample app, unit tests
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps