Add SentrySerialized to ReactNativeWritable convertor, load device context from sentry-java scope by krystofwoldrich · Pull Request #3170 · getsentry/sentry-react-native

krystofwoldrich · 2023-07-10T07:25:39Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Uses the new serialization interface from sentry-java to sync scope from Android SDK to the React Native SDK.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

Add tests for the JavaConvertor

…ntext from sentry-java scope

github-actions · 2023-07-10T08:15:02Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1248.33 ms	1259.18 ms	10.85 ms
Size	2.92 MiB	3.42 MiB	512.62 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`e2b64fe`+dirty	1285.78 ms	1297.56 ms	11.78 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`9a3ca65`+dirty	1276.40 ms	1279.14 ms	2.74 ms
`34aba08`+dirty	1268.58 ms	1276.80 ms	8.22 ms
`52a8031`+dirty	1255.96 ms	1273.00 ms	17.04 ms
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms

App size

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`e2b64fe`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`9a3ca65`+dirty	2.92 MiB	3.37 MiB	464.32 KiB
`34aba08`+dirty	2.92 MiB	3.41 MiB	499.03 KiB
`52a8031`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB

android/src/main/java/io/sentry/react/MapConverter.java

.github/workflows/native-tests.yml

github-actions · 2023-07-11T16:14:29Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1289.92 ms	1294.54 ms	4.62 ms
Size	2.36 MiB	2.86 MiB	508.80 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`9a3ca65`+dirty	1247.06 ms	1274.58 ms	27.52 ms
`34aba08`+dirty	1276.78 ms	1308.52 ms	31.74 ms
`52a8031`+dirty	1280.88 ms	1289.78 ms	8.90 ms
`15c80ab`+dirty	1223.74 ms	1228.96 ms	5.22 ms
`70caa60`+dirty	1218.27 ms	1230.30 ms	12.03 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms

App size

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`9a3ca65`+dirty	2.36 MiB	2.82 MiB	462.89 KiB
`34aba08`+dirty	2.36 MiB	2.85 MiB	495.32 KiB
`52a8031`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`15c80ab`+dirty	2.36 MiB	2.83 MiB	474.49 KiB
`70caa60`+dirty	2.36 MiB	2.83 MiB	479.27 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB

krystofwoldrich · 2023-07-13T14:05:49Z

Example run of the Android Tester tests.

github-actions · 2023-07-13T14:27:40Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	266.41 ms	334.17 ms	67.75 ms
Size	7.15 MiB	8.09 MiB	965.63 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms
`34aba08`+dirty	331.79 ms	376.69 ms	44.91 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms

App size

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB
`34aba08`+dirty	7.15 MiB	8.07 MiB	946.13 KiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB

This reverts commit 35e8aba.

github-actions · 2023-07-13T15:32:39Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	352.89 ms	372.08 ms	19.19 ms
Size	17.73 MiB	19.82 MiB	2.09 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`34aba08`	328.10 ms	342.84 ms	14.74 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`3853f43`	329.68 ms	346.32 ms	16.64 ms
`0db0c72`	372.12 ms	386.00 ms	13.88 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms

App size

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`34aba08`	17.73 MiB	19.80 MiB	2.07 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`3853f43`	17.73 MiB	19.81 MiB	2.08 MiB
`0db0c72`	17.73 MiB	19.75 MiB	2.02 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB

...ryAndroidTester/app/src/androidTest/java/io/sentry/rnsentryandroidtester/MapConverterTest.kt

android/src/main/java/io/sentry/react/RNSentryModuleImpl.java

src/js/NativeRNSentry.ts

krystofwoldrich · 2023-07-19T10:09:35Z

@marandaneto I've updated the PR, thank you for the comments.

This reverts commit f24552e.

android/build.gradle

marandaneto · 2023-07-24T11:06:40Z

getsentry/sentry-java#2814 (comment) still pending, I'd address that before merging/releasing.

…enrichment

CHANGELOG.md

…enrichment

Krystof Woldrich added 2 commits July 10, 2023 09:21

Add SentrySerialized to ReactNativeWritable convertor, load device co…

5b6a0f9

…ntext from sentry-java scope

Update changelog

0baa9de

krystofwoldrich mentioned this pull request Jul 10, 2023

Add API to retrieve Android scope data getsentry/sentry-java#2814

Merged

7 tasks

Add RNSentryAndroidTester project to test the RNSentry Android module

a867f8a

krystofwoldrich commented Jul 10, 2023

View reviewed changes

android/src/main/java/io/sentry/react/MapConverter.java Show resolved Hide resolved

Add android CI tests

f1d91dc

github-actions bot reviewed Jul 10, 2023

View reviewed changes

.github/workflows/native-tests.yml Show resolved Hide resolved

Krystof Woldrich added 4 commits July 10, 2023 17:11

Add android tests to CI, add basic key value converter tests

0a163ea

Fix emulator working dir

da1b6a8

Add tests

5ed7083

Update devicecontext to use both context and contexts fields

a864fff

Krystof Woldrich added 2 commits July 13, 2023 15:38

tmp: comment out internal to test android tester ci

35e8aba

Update converter for long and other big numbers

65211d0

Krystof Woldrich added 3 commits July 13, 2023 17:05

Fix JS tests JS keeps breadcrumbs on android

74b5094

Update changelog

48b73f8

Revert "tmp: comment out internal to test android tester ci"

cc655e3

This reverts commit 35e8aba.

Restore getscope and captureenvelope, lint imports

9d59cb3

krystofwoldrich marked this pull request as ready for review July 13, 2023 15:49

krystofwoldrich requested review from lucas-zimerman and marandaneto as code owners July 13, 2023 15:49

krystofwoldrich requested a review from markushi July 17, 2023 12:56

marandaneto reviewed Jul 18, 2023

View reviewed changes

...ryAndroidTester/app/src/androidTest/java/io/sentry/rnsentryandroidtester/MapConverterTest.kt Outdated Show resolved Hide resolved

marandaneto reviewed Jul 18, 2023

View reviewed changes

android/src/main/java/io/sentry/react/RNSentryModuleImpl.java Outdated Show resolved Hide resolved

marandaneto reviewed Jul 18, 2023

View reviewed changes

android/src/main/java/io/sentry/react/RNSentryModuleImpl.java Outdated Show resolved Hide resolved

marandaneto reviewed Jul 18, 2023

View reviewed changes

src/js/NativeRNSentry.ts Outdated Show resolved Hide resolved

Krystof Woldrich added 3 commits July 19, 2023 10:30

Update Android SDK, fix ts types

c8564c6

Rename cocoa context to contexts to unify the naming

583b86c

Add android sdk info

a8a0713

krystofwoldrich requested a review from marandaneto July 19, 2023 10:09

Krystof Woldrich added 6 commits July 19, 2023 12:20

Fix node version for e2e tests

0058ec1

Fix node for newer rn versions

011bbe4

Fix cocoa tester scheme name

cf51653

Revert "Use backticks for tests names"

113b6f7

This reverts commit f24552e.

convert test names to camel case

01a4c6f

Remove unit tests, we don't have any at the moment

60f0620

kahest mentioned this pull request Jul 20, 2023

Align how we enrich the event with device context on Hybrid SDKs getsentry/team-mobile#11

Closed

marandaneto mentioned this pull request Jul 24, 2023

Enrich event with Android context on the Dart layer getsentry/sentry-dart#1556

Closed

marandaneto reviewed Jul 24, 2023

View reviewed changes

android/build.gradle Outdated Show resolved Hide resolved

Krystof Woldrich added 4 commits July 25, 2023 14:44

Merge remote-tracking branch 'origin/main' into kw-android-new-event-…

8cc59fa

…enrichment

Add clean emulator step to native android tests

0b1e855

Run clean emulator with emulator running

b29c3bb

Bump Android SDK to 6.27.0

48d2ba9

marandaneto reviewed Jul 26, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

marandaneto approved these changes Jul 26, 2023

View reviewed changes

Krystof Woldrich added 2 commits July 26, 2023 12:19

Merge remote-tracking branch 'origin/HEAD' into kw-android-new-event-…

e29f4dc

…enrichment

Update changelog

fdb07b3

krystofwoldrich enabled auto-merge (squash) July 26, 2023 10:28

krystofwoldrich merged commit b0855ef into main Jul 26, 2023

krystofwoldrich deleted the kw-android-new-event-enrichment branch July 26, 2023 10:31

marandaneto mentioned this pull request Jul 26, 2023

Exception capture context is overwritten by native scope sync #2146

Closed

krystofwoldrich mentioned this pull request Jul 27, 2023

Fix node version for e2e tests #3213

Closed

denrase mentioned this pull request Aug 29, 2023

Load Device Contexts from Sentry Java getsentry/sentry-dart#1616

Merged

6 tasks

krystofwoldrich mentioned this pull request Apr 30, 2024

Add tests for the Native Bridges #1874

Closed

Uh oh!

Comments

Conversation

krystofwoldrich commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

krystofwoldrich commented Jul 13, 2023

Uh oh!

github-actions bot commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krystofwoldrich commented Jul 19, 2023

Uh oh!

Uh oh!

marandaneto commented Jul 24, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

krystofwoldrich commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 11, 2023 •

edited

Loading

github-actions bot commented Jul 13, 2023 •

edited

Loading

github-actions bot commented Jul 13, 2023 •

edited

Loading