getsentry · krystofwoldrich · Mar 21, 2023 · Feb 17, 2023 · Feb 20, 2023 · Feb 20, 2023
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Features
+
+- Add User Interaction Tracing for Touch events ([#2835](https://github.com/getsentry/sentry-react-native/pull/2835))
+
 ### Fixes
 
 - Fix use Fetch transport when option `enableNative` is `false` ([#2897](https://github.com/getsentry/sentry-react-native/pull/2897))

@@ -41,6 +41,7 @@ Sentry.init({
         idleTimeout: 5000,
         routingInstrumentation: reactNavigationInstrumentation,
         tracingOrigins: ['localhost', /^\//, /^https:\/\//],
+        enableUserInteractionTracing: true,
         beforeNavigate: (context: Sentry.ReactNavigationTransactionContext) => {
           // Example of not sending a transaction for the screen with the name "Manual Tracker"
           if (context.data.route.name === 'ManualTracker') {

@@ -71,7 +71,7 @@ const TrackerScreen = () => {
           <ActivityIndicator size="small" color="#F6F6F8" />
         )}
       </View>
-      <Button title="Refresh" onPress={loadData} />
+      <Button sentry-label="refresh" title="Refresh" onPress={loadData} />
     </View>
   );
 };

@@ -5,6 +5,8 @@ import * as React from 'react';
 import { StyleSheet, View } from 'react-native';
 
 import { createIntegration } from './integrations/factory';
+import { ReactNativeTracing } from './tracing';
+import { UI_ACTION_TOUCH } from './tracing/ops';
 
 export type TouchEventBoundaryProps = {
   /**
@@ -49,7 +51,7 @@ const DEFAULT_BREADCRUMB_CATEGORY = 'touch';
 const DEFAULT_BREADCRUMB_TYPE = 'user';
 const DEFAULT_MAX_COMPONENT_TREE_SIZE = 20;
 
-const PROP_KEY = 'sentry-label';
+const SENTRY_LABEL_PROP_KEY = 'sentry-label';
 
 interface ElementInstance {
   elementType?: {
@@ -64,6 +66,7 @@ interface ElementInstance {
  * Boundary to log breadcrumbs for interaction events.
  */
 class TouchEventBoundary extends React.Component<TouchEventBoundaryProps> {
+
   public static displayName: string = '__Sentry.TouchEventBoundary';
   public static defaultProps: Partial<TouchEventBoundaryProps> = {
     breadcrumbCategory: DEFAULT_BREADCRUMB_CATEGORY,
@@ -74,11 +77,17 @@ class TouchEventBoundary extends React.Component<TouchEventBoundaryProps> {
 
   public readonly name: string = 'TouchEventBoundary';
 
+  private _tracingIntegration: ReactNativeTracing | null = null;
+
   /**
    * Registers the TouchEventBoundary as a Sentry Integration.
    */
   public componentDidMount(): void {
-    getCurrentHub().getClient()?.addIntegration?.(createIntegration(this.name));
+    const client = getCurrentHub().getClient();
+    client?.addIntegration?.(createIntegration(this.name));
+    if (!this._tracingIntegration && client) {
+      this._tracingIntegration = client.getIntegration(ReactNativeTracing);
+    }
   }
 
   /**
@@ -147,77 +156,84 @@ class TouchEventBoundary extends React.Component<TouchEventBoundaryProps> {
    */
   // eslint-disable-next-line complexity
   private _onTouchStart(e: { _targetInst?: ElementInstance }): void {
-    if (e._targetInst) {
-      let currentInst: ElementInstance | undefined = e._targetInst;
-
-      let activeLabel: string | undefined;
-      let activeDisplayName: string | undefined;
-      const componentTreeNames: string[] = [];
-
-      while (
-        currentInst &&
-        // maxComponentTreeSize will always be defined as we have a defaultProps. But ts needs a check so this is here.
-        this.props.maxComponentTreeSize &&
-        componentTreeNames.length < this.props.maxComponentTreeSize
+    if (!e._targetInst) {
+      return;
+    }
+
+    let currentInst: ElementInstance | undefined = e._targetInst;
+
+    let activeLabel: string | undefined;
+    let activeDisplayName: string | undefined;
+    const componentTreeNames: string[] = [];
+
+    while (
+      currentInst &&
+      // maxComponentTreeSize will always be defined as we have a defaultProps. But ts needs a check so this is here.
+      this.props.maxComponentTreeSize &&
+      componentTreeNames.length < this.props.maxComponentTreeSize
+    ) {
+      if (
+        // If the loop gets to the boundary itself, break.
+        currentInst.elementType?.displayName ===
+        TouchEventBoundary.displayName
       ) {
-        if (
-          // If the loop gets to the boundary itself, break.
-          currentInst.elementType?.displayName ===
-          TouchEventBoundary.displayName
-        ) {
-          break;
+        break;
+      }
+
+      const props = currentInst.memoizedProps;
+      const sentryLabel =
+        typeof props?.[SENTRY_LABEL_PROP_KEY] !== 'undefined'
+          ? `${props[SENTRY_LABEL_PROP_KEY]}`
+          : undefined;
+
+      // For some reason type narrowing doesn't work as expected with indexing when checking it all in one go in
+      // the "check-label" if sentence, so we have to assign it to a variable here first
+      let labelValue;
+      if (typeof this.props.labelName === 'string')
+        labelValue = props?.[this.props.labelName];
+
+      // Check the label first
+      if (sentryLabel && !this._isNameIgnored(sentryLabel)) {
+        if (!activeLabel) {
+          activeLabel = sentryLabel;
+        }
+        componentTreeNames.push(sentryLabel);
+      } else if (
+        typeof labelValue === 'string' &&
+        !this._isNameIgnored(labelValue)
+      ) {
+        if (!activeLabel) {
+          activeLabel = labelValue;
         }
+        componentTreeNames.push(labelValue);
+      } else if (currentInst.elementType) {
+        const { elementType } = currentInst;
 
-        const props = currentInst.memoizedProps;
-        const label =
-          typeof props?.[PROP_KEY] !== 'undefined'
-            ? `${props[PROP_KEY]}`
-            : undefined;
-
-        // For some reason type narrowing doesn't work as expected with indexing when checking it all in one go in
-        // the "check-label" if sentence, so we have to assign it to a variable here first
-        let labelValue;
-        if (typeof this.props.labelName === 'string')
-          labelValue = props?.[this.props.labelName];
-
-        // Check the label first
-        if (label && !this._isNameIgnored(label)) {
-          if (!activeLabel) {
-            activeLabel = label;
-          }
-          componentTreeNames.push(label);
-        } else if (
-          typeof labelValue === 'string' &&
-          !this._isNameIgnored(labelValue)
+        if (
+          elementType.displayName &&
+          !this._isNameIgnored(elementType.displayName)
         ) {
-          if (!activeLabel) {
-            activeLabel = labelValue;
-          }
-          componentTreeNames.push(labelValue);
-        } else if (currentInst.elementType) {
-          const { elementType } = currentInst;
-
-          if (
-            elementType.displayName &&
-            !this._isNameIgnored(elementType.displayName)
-          ) {
-            // Check display name
-            if (!activeDisplayName) {
-              activeDisplayName = elementType.displayName;
-            }
-            componentTreeNames.push(elementType.displayName);
+          // Check display name
+          if (!activeDisplayName) {
+            activeDisplayName = elementType.displayName;
           }
+          componentTreeNames.push(elementType.displayName);
         }
-
-        currentInst = currentInst.return;
       }
 
-      const finalLabel = activeLabel ?? activeDisplayName;
+      currentInst = currentInst.return;
+    }
 
-      if (componentTreeNames.length > 0 || finalLabel) {
-        this._logTouchEvent(componentTreeNames, finalLabel);
-      }
+    const finalLabel = activeLabel ?? activeDisplayName;
+
+    if (componentTreeNames.length > 0 || finalLabel) {
+      this._logTouchEvent(componentTreeNames, finalLabel);
     }
+
+    this._tracingIntegration?.startUserInteractionTransaction({
+      elementId: activeLabel,
+      op: UI_ACTION_TOUCH,
+    });
   }
 }
 

@@ -1,7 +1,9 @@
 
 export const DEFAULT = 'default';
-export const UI_LOAD = 'ui.load';
 export const NAVIGATION = 'navigation';
 
+export const UI_LOAD = 'ui.load';
+export const UI_ACTION_TOUCH = 'ui.action.touch';
+
 export const APP_START_COLD = 'app.start.cold';
 export const APP_START_WARM = 'app.start.warm';
@@ -1,12 +1,15 @@
 /* eslint-disable max-lines */
 import type { Hub } from '@sentry/core';
+import { getCurrentHub } from '@sentry/core';
 import type {
   IdleTransaction,
   RequestInstrumentationOptions,
   Transaction
 } from '@sentry/tracing';
 import {
   defaultRequestInstrumentationOptions,
+  getActiveTransaction
+  ,
   instrumentOutgoingRequests,
   startIdleTransaction
 } from '@sentry/tracing';
@@ -29,6 +32,9 @@ import {
   UI_LOAD,
 } from './ops';
 import { StallTrackingInstrumentation } from './stalltracking';
+import {
+  onlySampleIfChildSpans,
+} from './transaction';
 import type { BeforeNavigate, RouteChangeContextData } from './types';
 import {
   adjustTransactionDuration,
@@ -108,6 +114,11 @@ export interface ReactNativeTracingOptions
    * Track when and how long the JS event loop stalls for. Adds stalls as measurements to all transactions.
    */
   enableStallTracking: boolean;
+
+  /**
+   * Trace User Interaction events like touch and gestures.
+   */
+  enableUserInteractionTracing: boolean;
 }
 
 const defaultReactNativeTracingOptions: ReactNativeTracingOptions = {
@@ -121,6 +132,7 @@ const defaultReactNativeTracingOptions: ReactNativeTracingOptions = {
   enableAppStartTracking: true,
   enableNativeFramesTracking: true,
   enableStallTracking: true,
+  enableUserInteractionTracing: false,
 };
 
 /**
@@ -145,9 +157,11 @@ export class ReactNativeTracing implements Integration {
   public stallTrackingInstrumentation?: StallTrackingInstrumentation;
   public useAppStartWithProfiler: boolean = false;
 
+  private _inflightInteractionTransaction?: IdleTransaction;
   private _getCurrentHub?: () => Hub;
   private _awaitingAppStartData?: NativeAppStartResponse;
   private _appStartFinishTimestamp?: number;
+  private _currentRoute?: string;
 
   public constructor(options: Partial<ReactNativeTracingOptions> = {}) {
     this.options = {
@@ -271,6 +285,71 @@ export class ReactNativeTracing implements Integration {
     this._appStartFinishTimestamp = endTimestamp;
   }
 
+  /**
+   * Starts a new transaction for a user interaction.
+   * @param userInteractionId Consists of `op` representation UI Event and `elementId` unique element identifier on current screen.
+   */
+  public startUserInteractionTransaction(userInteractionId: {
+    elementId: string | undefined;
+    op: string;
+  }): TransactionType | undefined {
+    const { elementId, op } = userInteractionId;
+    if (!this.options.enableUserInteractionTracing) {
+      logger.log('[ReactNativeTracing] User Interaction Tracing is disabled.');
+      return;
+    }
+    if (!this.options.routingInstrumentation) {
+      logger.error('[ReactNativeTracing] User Interaction Tracing is not working because no routing instrumentation is set.');
+      return;
+    }
+    if (!elementId) {
+      logger.log('[ReactNativeTracing] User Interaction Tracing can not create transaction with undefined elementId.');
+      return;
+    }
+    if (!this._currentRoute) {
+      logger.log('[ReactNativeTracing] User Interaction Tracing can not create transaction without a current route.');
+      return;
+    }
+
+    const hub = this._getCurrentHub?.() || getCurrentHub();
+    const activeTransaction = getActiveTransaction(hub);
+    const activeTransactionIsNotInteraction =
+      activeTransaction?.spanId !== this._inflightInteractionTransaction?.spanId;
+    if (activeTransaction && activeTransactionIsNotInteraction) {
+      logger.warn(`[ReactNativeTracing] Did not create ${op} transaction because active transaction ${activeTransaction.name} exists on the scope.`);
+      return;
+    }
+
+    const { idleTimeoutMs, finalTimeoutMs } = this.options;
+
+    if (this._inflightInteractionTransaction) {
+      this._inflightInteractionTransaction.cancelIdleTimeout(undefined, { restartOnChildSpanChange: false });
+      this._inflightInteractionTransaction = undefined;
+    }
+
+    const name = `${this._currentRoute}.${elementId}`;
+    const context: TransactionContext = {
+      name,
+      op,
+      trimEnd: true,
+    };
+    this._inflightInteractionTransaction = startIdleTransaction(
+      hub,
+      context,
+      idleTimeoutMs,
+      finalTimeoutMs,
+      true,
+    );
+    this._inflightInteractionTransaction.registerBeforeFinishCallback((transaction: IdleTransaction) => {
+      this._inflightInteractionTransaction = undefined;
+      this.onTransactionFinish(transaction);
+    });
+    this._inflightInteractionTransaction.registerBeforeFinishCallback(onlySampleIfChildSpans);
+    this.onTransactionStart(this._inflightInteractionTransaction);
+    logger.log(`[ReactNativeTracing] User Interaction Tracing Created ${op} transaction ${name}.`);
+    return this._inflightInteractionTransaction;
+  }
+
   /**
    * Instruments the app start measurements on the first route transaction.
    * Starts a route transaction if there isn't routing instrumentation.
@@ -354,6 +433,9 @@ export class ReactNativeTracing implements Integration {
    * Creates a breadcrumb and sets the current route as a tag.
    */
   private _onConfirmRoute(context: TransactionContext): void {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+    this._currentRoute = context.data?.route?.name;
+
     this._getCurrentHub?.().configureScope((scope) => {
       if (context.data) {
         const contextData = context.data as RouteChangeContextData;
@@ -385,6 +467,14 @@ export class ReactNativeTracing implements Integration {
       return undefined;
     }
 
+    if (this._inflightInteractionTransaction) {
+      logger.log(
+        `[ReactNativeTracing] Canceling ${this._inflightInteractionTransaction.op} transaction because navigation ${context.op}.`
+      );
+      this._inflightInteractionTransaction.setStatus('cancelled');
+      this._inflightInteractionTransaction.finish();
+    }
+
     // eslint-disable-next-line @typescript-eslint/unbound-method
     const { idleTimeoutMs, finalTimeoutMs } = this.options;
-Original file line number
+Diff line change
@@ Expand Up / @@ -71,7 +71,7 @@ const TrackerScreen = () => { @@
               <ActivityIndicator size="small" color="#F6F6F8" />
             )}
           </View>
-          <Button title="Refresh" onPress={loadData} />
+          <Button sentry-label="refresh" title="Refresh" onPress={loadData} />
         </View>
       );
     };
@@ Expand Down @@