Skip to content

Fix: Set default unit for measurements#2360

Merged
marandaneto merged 8 commits into
mainfrom
fix/measurements-unit
Jul 11, 2022
Merged

Fix: Set default unit for measurements#2360
marandaneto merged 8 commits into
mainfrom
fix/measurements-unit

Conversation

@marandaneto

@marandaneto marandaneto commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fix: Set default unit for measurements

💡 Motivation and Context

getsentry/team-mobile#31
app_start_cold, stall_total_time and stall_longest_time were sending unit = '' and this was causing issues during ingestion.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto
marandaneto marked this pull request as ready for review July 8, 2022 11:42
@marandaneto
marandaneto requested a review from bruno-garcia as a code owner July 8, 2022 11:42
@marandaneto
marandaneto requested a review from jjbayer July 11, 2022 06:31

@jjbayer jjbayer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Units look good to me!

@marandaneto
marandaneto merged commit 0da2a1d into main Jul 11, 2022
@marandaneto
marandaneto deleted the fix/measurements-unit branch July 11, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants